Adopt upstream llvm-project monorepo directory layout#13049
Conversation
hahnjo
requested review from
Axel-Naumann,
bellenot,
couet,
pcanal and
vgvassilev
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Before I review and out of curiosity, did you consider If so, would |
Yes, and two consequences thereof: (a) I want to avoid a conflict further down the line if LLVM ever puts a
Yes, I'm open to that - I thought about it, but it requires changing a few more paths to |
ie what breaks with #13054 ? |
Never mind then, I don't have a strong enough opinion on this to trigger extra work. |
|
I'm willing to spend that extra work if it's the better layout - it's likely to survive quite some time, so I think it's better not to compromise right now... |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Now everything seems clean, and I will proceed to merge this during the weekend - incremental builds across this change won't work very nicely, I will post a note on Mattermost after it's in. |
This will be required for future LLVM upgrades that rely on a common cmake/ directory next to clang/ and llvm/. This commit is the result of the following commands: $ mkdir interpreter/llvm-project/ $ git mv interpreter/llvm/src/tools/clang/ interpreter/llvm-project/clang/ $ git mv interpreter/llvm/src/ interpreter/llvm-project/llvm/ $ git mv interpreter/llvm/llvm-project.tag interpreter/llvm-project/llvm-project.tag
|
Starting build on |
|
Build failed on ROOT-debian10-i386/soversion. Errors:
|
|
Build failed on mac12arm/cxx20. Failing tests: |
…3049) This will be required for future LLVM upgrades that rely on a common cmake/ directory next to clang/ and llvm/. The bulk of this change is the result of the following commands: $ mkdir interpreter/llvm-project/ $ git mv interpreter/llvm/src/tools/clang/ interpreter/llvm-project/clang/ $ git mv interpreter/llvm/src/ interpreter/llvm-project/llvm/ $ git mv interpreter/llvm/llvm-project.tag interpreter/llvm-project/llvm-project.tag
4 participants
This will be required for future LLVM upgrades that rely on a common
cmake/directory next toclang/andllvm/.To have any chance at reviewing this change, the mechanical moving is in the first commit and the other two commits are the actual changes (build system, then
llvm-diffworkflow). I will squash the commits on merge because the state after the first commit obviously won't build.