Remove header copying in core/clingutils

[hahnjo]

No description provided.

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

[Axel-Naumann]

Standalone cling doesn't use modules; does it work even without copying headers, in a relocatable way? We might be able to turn this off for ROOT though.

[hahnjo]

Standalone cling doesn't use modules; does it work even without copying headers, in a relocatable way? We might be able to turn this off for ROOT though.

Unless I'm missing something obvious here, this isn't used for Cling standalone at all - core/clingutils/CMakeLists.txt is a ROOT thing, no?

[Axel-Naumann]

🤦

[github-actions]

Test Results

       11 files         11 suites   2d 2h 12m 23s ⏱️
  2 469 tests   2 469 ✔️ 0 💤 0 ❌
25 483 runs  25 483 ✔️ 0 💤 0 ❌

Results for commit cff6b1b.

[Axel-Naumann]

You should also test with -Druntime_cxxmodules=Off, please.

[hahnjo]

@phsft-bot build with flags -Druntime_cxxmodules=Off -DCTEST_TEST_EXCLUDE_NONE=On

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 with flags -Druntime_cxxmodules=Off -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

[phsft-bot]

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.runtutorials.tutorial_rcanvas_rh1.cxx
• projectroot.runtutorials.tutorial_v7_histops.cxx
• projectroot.runtutorials.tutorial_rcanvas_rh1_twoscales.cxx
• projectroot.runtutorials.tutorial_v7_perfcomp.cxx
• projectroot.runtutorials.tutorial_rcanvas_rcanvas_mt.cxx
• projectroot.runtutorials.tutorial_rcanvas_rh1_large.cxx
• projectroot.runtutorials.tutorial_v7_perf.cxx
• projectroot.runtutorials.tutorial_v7_concurrentfill.cxx
• projectroot.runtutorials.tutorial_v7_simple.cxx
• projectroot.runtutorials.tutorial_rcanvas_rh2_colz.cxx

And 8 more

[phsft-bot]

Build failed on mac12arm/cxx20.
Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_importROOT_notebook
• projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_simpleCppMagic_notebook
• projectroot.tree.ntuple.v7.test.gtest_tree_ntuple_v7_test_ntuple_types

[phsft-bot]

Build failed on mac11/noimt.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_importROOT_notebook
• projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_simpleCppMagic_notebook

[hahnjo]

Build failed on ROOT-performance-centos8-multicore/cxx17.

These failure are pre-existing, I opened #13058.

I briefly discussed with Axel, and we decided to merge this for now. In the worst case, somebody building their own ROOT binaries without C++ runtime modules will complain when installing on a system with non-matching headers, in which case we'll investigate (hopefully all experiments enable C++ runtime modules by now).

[vgvassilev]

That looks reasonable to me.