[RF][HS3] Fixes for ATLAS usecase by cburgard · Pull Request #14289 · root-project/root

cburgard · 2023-12-21T07:49:38Z

This Pull request:

Fixes various small bugs, makes the implementation more robust and improves error reporting for JSON import of HS3 files.

Changes or fixes:

errors from the nlohmann_json importer are now correctly forwarded to the user, rather than giving an unspecific "std_exception".
some missing keys or values no longer trigger segfaults, but instead lead to an actual error being emitted. this includes errors being emitted by ParamHistFuncs if the number of bins is incorrect.
the version tag has been correctly updated to 0.2
gaussians can now be imported with "normal_dist" as well, as described by the standard
the implementation is a bit more lenient when missing some values (e.g. ignoring cases where the histfactory modifier name has been omitted and instead just numbers the systematics)
the list of variables in the workspace is now no longer just filled from the parameter_points, but also from the domains, allowing cases where no parameter points are given to be imported successfully

Checklist:

tested changes locally
updated the docs (if necessary)

This PR fixes #

phsft-bot · 2023-12-21T07:49:41Z

Can one of the admins verify this patch?

guitargeek · 2023-12-21T11:35:23Z

@phsft-bot build

phsft-bot · 2023-12-21T11:35:29Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2023-12-21T12:37:46Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_roofit_rf515_hfJSON_py

phsft-bot · 2023-12-21T13:12:11Z

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_roofit_rf515_hfJSON_py

github-actions · 2023-12-22T13:51:06Z

Test Results

9 files 9 suites 2d 6h 1m 24s ⏱️
2 491 tests 2 482 ✅ 0 💤 9 ❌
21 387 runs 21 378 ✅ 0 💤 9 ❌

For more details on these failures, see this check.

Results for commit b7d87f83.

♻️ This comment has been updated with latest results.

Gaussians can now be imported with "normal_dist" as well, as described by the standard.

Errors from the nlohmann_json importer are now correctly forwarded to the user, rather than giving an unspecific "std_exception".

The implementation is a bit more lenient when missing some values (e.g. ignoring cases where the histfactory modifier name has been omitted and instead just numbers the systematics)

The list of variables in the workspace is now no longer just filled from the parameter_points, but also from the domains, allowing cases where no parameter points are given to be imported successfully. Also, the HS3 version tag has been correctly updated to 0.2.

guitargeek · 2024-01-22T21:48:04Z

@phsft-bot build

phsft-bot · 2024-01-22T21:48:12Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

phsft-bot · 2024-01-22T22:36:24Z

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_roofit_rf515_hfJSON_py

phsft-bot · 2024-01-22T22:39:28Z

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_roofit_rf515_hfJSON_py

guitargeek · 2024-01-22T22:40:29Z

@phsft-bot build

phsft-bot · 2024-01-22T22:40:37Z

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

cburgard requested review from Axel-Naumann, guitargeek, hageboeck and lmoneta as code owners December 21, 2023 07:49

martamaja10 assigned cburgard Dec 21, 2023

martamaja10 added the in:RooFit label Dec 21, 2023

martamaja10 assigned guitargeek Dec 21, 2023

guitargeek force-pushed the hs3-bugfixes-63002-contd branch from be130d0 to 6bc4789 Compare December 22, 2023 11:22

guitargeek force-pushed the hs3-bugfixes-63002-contd branch from 6bc4789 to d1deb38 Compare January 22, 2024 21:28

cburgard requested a review from dpiparo as a code owner January 22, 2024 21:28

guitargeek removed request for Axel-Naumann, dpiparo, hageboeck and lmoneta January 22, 2024 21:28

cburgard added 6 commits January 22, 2024 22:43

[RF] Error message in ParamHistFunc::getParameter() for invalid index

07c5670

[RF][HS3] Added importer for normal_dist

cdcd574

Gaussians can now be imported with "normal_dist" as well, as described by the standard.

[RF][HS3] Improved error reporting from JSON parsing errors

49ccf70

Errors from the nlohmann_json importer are now correctly forwarded to the user, rather than giving an unspecific "std_exception".

[RF][HS3] Improved robustness, removed warnings

b2b57ca

The implementation is a bit more lenient when missing some values (e.g. ignoring cases where the histfactory modifier name has been omitted and instead just numbers the systematics)

[RF][HS3] Add method to fill workspace with all variables in "domains"

a726681

guitargeek mentioned this pull request Jan 22, 2024

[RF] RooFit open issues and backports for 6.30 releases #13458

Closed

23 tasks

guitargeek changed the title ~~[RF][HS3]~~ [RF][HS3] Fixes for ATLAS usecase Jan 22, 2024

guitargeek mentioned this pull request Jan 22, 2024

[v630][RF] Backports of RooFit PRs to v6-30-00-patches: Part 9 #14407

Merged

guitargeek force-pushed the hs3-bugfixes-63002-contd branch from d1deb38 to b7d87f8 Compare January 22, 2024 22:40

guitargeek approved these changes Jan 23, 2024

View reviewed changes

guitargeek merged commit 9fe2922 into root-project:master Jan 23, 2024

guitargeek deleted the hs3-bugfixes-63002-contd branch January 23, 2024 09:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[RF][HS3] Fixes for ATLAS usecase#14289

[RF][HS3] Fixes for ATLAS usecase#14289
guitargeek merged 6 commits into
root-project:masterfrom
cburgard:hs3-bugfixes-63002-contd

cburgard commented Dec 21, 2023 •

edited

Loading

Uh oh!

phsft-bot commented Dec 21, 2023

Uh oh!

guitargeek commented Dec 21, 2023

Uh oh!

phsft-bot commented Dec 21, 2023

Uh oh!

phsft-bot commented Dec 21, 2023

Uh oh!

phsft-bot commented Dec 21, 2023

Uh oh!

github-actions Bot commented Dec 22, 2023 •

edited

Loading

Uh oh!

guitargeek commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Uh oh!

guitargeek commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

cburgard commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This Pull request:

Changes or fixes:

Checklist:

Uh oh!

phsft-bot commented Dec 21, 2023

Uh oh!

guitargeek commented Dec 21, 2023

Uh oh!

phsft-bot commented Dec 21, 2023

Uh oh!

phsft-bot commented Dec 21, 2023

Failing tests:

Uh oh!

phsft-bot commented Dec 21, 2023

Failing tests:

Uh oh!

github-actions Bot commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

guitargeek commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Failing tests:

Uh oh!

phsft-bot commented Jan 22, 2024

Failing tests:

Uh oh!

guitargeek commented Jan 22, 2024

Uh oh!

phsft-bot commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cburgard commented Dec 21, 2023 •

edited

Loading

github-actions Bot commented Dec 22, 2023 •

edited

Loading