[v630][RF] Backports of RooFit PRs to v6-30-00-patches: Part 9#14407
Merged
guitargeek merged 10 commits intoJan 23, 2024
Merged
Conversation
…ero errors Fix the case of using KS test when one of the histogram has zero errors (i.e is a function). Improve KS test adding possibility to specify number of toys by using option "X=number" for example "X=1000" This fixes the issue root-project#13697
Use as parent distribution for generating the toys for the NULL distribution of the test statistics the histogram with higer statistics. If it is a function use that one as parent. This commit takes into account the comment of Jonas in the PR
Calling GSLMCIntegrator::SetMode crashed because the internal workspace wss not yet created. This is now fixed and also the way the extra option parameters are retrieved and set. Avoid now potential memory leak by using a unique_ptr
use MakeIOptions() instead of operator()
Gaussians can now be imported with "normal_dist" as well, as described by the standard.
Errors from the nlohmann_json importer are now correctly forwarded to the user, rather than giving an unspecific "std_exception".
The implementation is a bit more lenient when missing some values (e.g. ignoring cases where the histfactory modifier name has been omitted and instead just numbers the systematics)
The list of variables in the workspace is now no longer just filled from the parameter_points, but also from the domains, allowing cases where no parameter points are given to be imported successfully. Also, the HS3 version tag has been correctly updated to 0.2.
guitargeek
requested review from
Axel-Naumann,
hageboeck and
lmoneta
as code owners
January 22, 2024 21:57
|
Starting build on |
guitargeek
changed the title
v6-30-00-patches: Part 9
23 tasks
Test Results 9 files 9 suites 1d 9h 45m 14s ⏱️ For more details on these failures, see this check. Results for commit 132824b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of some RooFit PRs that were recently merged to master to v6-30-00-patches:
Related to #13458.
Link to the previous backport PR:
#14252