Skip to content

[RF] Set workspace on imported roofit objects#14759

Merged
guitargeek merged 1 commit into
root-project:masterfrom
will-cern:workspaceImportFix
Feb 20, 2024
Merged

[RF] Set workspace on imported roofit objects#14759
guitargeek merged 1 commit into
root-project:masterfrom
will-cern:workspaceImportFix

Conversation

@will-cern

@will-cern will-cern commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

Imported RooAbsArgs should have their workspace set to the workspace they are being imported to.

Can we please sweep this into 6.30 patches too please.

@phsft-bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@guitargeek guitargeek self-assigned this Feb 19, 2024
@guitargeek

Copy link
Copy Markdown
Contributor

@phsft-bot build

@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@guitargeek guitargeek changed the title set workspace on imported roofit objects [RF] Set workspace on imported roofit objects Feb 19, 2024
@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@github-actions

Copy link
Copy Markdown

Test Results

    12 files      12 suites   2d 7h 58m 2s ⏱️
 2 561 tests  2 559 ✅ 0 💤 2 ❌
28 810 runs  28 807 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 5710a61.

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for fixing this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants