Skip to content

[v630][RF] Backports of RooFit PRs to v6-30-00-patches: Part 10#14768

Merged
guitargeek merged 3 commits into
root-project:v6-30-00-patchesfrom
guitargeek:v6-30-00-patches_backports_10
Feb 26, 2024
Merged

[v630][RF] Backports of RooFit PRs to v6-30-00-patches: Part 10#14768
guitargeek merged 3 commits into
root-project:v6-30-00-patchesfrom
guitargeek:v6-30-00-patches_backports_10

Conversation

@guitargeek

@guitargeek guitargeek commented Feb 20, 2024

Copy link
Copy Markdown
Contributor

This is a backport of some RooFit PRs that were recently merged to master to v6-30-00-patches:

Related to #13458.

Link to the previous backport PR:
#14407

@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@github-actions

Copy link
Copy Markdown

Test Results

    10 files      10 suites   1d 18h 30m 18s ⏱️
 2 488 tests  2 486 ✅ 0 💤 2 ❌
23 839 runs  23 836 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 2d85040.

will-cern and others added 3 commits February 26, 2024 13:28
Imported RooAbsArgs should have their workspace set to the workspace they are
being imported to.
Fixes issues with display of plots drawn by xRooFit in jupyter notebooks.
To avoid worry reports in the forum worrying about whether Minuit2 is gonna be removed.

See https://root-forum.cern.ch/t/will-minuit2-be-removed-from-root/58078

Also includes changes from commit d4acc52.
@guitargeek
guitargeek force-pushed the v6-30-00-patches_backports_10 branch from 2d85040 to ec4de4c Compare February 26, 2024 12:31
@guitargeek
guitargeek requested a review from bellenot as a code owner February 26, 2024 12:31
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@guitargeek
guitargeek merged commit a884b5e into root-project:v6-30-00-patches Feb 26, 2024
@guitargeek
guitargeek deleted the v6-30-00-patches_backports_10 branch February 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants