Skip to content

[RF] Fix for display of canvases in jupyter notebooks#14762

Merged
guitargeek merged 1 commit into
root-project:masterfrom
will-cern:xroofitUpdate
Feb 20, 2024
Merged

[RF] Fix for display of canvases in jupyter notebooks#14762
guitargeek merged 1 commit into
root-project:masterfrom
will-cern:xroofitUpdate

Conversation

@will-cern

Copy link
Copy Markdown
Contributor

This change needs backporting into 6.30

It fixes issues with display of plots drawn by xRooFit in jupyter notebooks.

@phsft-bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@guitargeek

Copy link
Copy Markdown
Contributor

@phsft-bot build

@guitargeek guitargeek self-assigned this Feb 19, 2024
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@guitargeek guitargeek changed the title Fix for display of canvases in jupyter notebooks [RF] Fix for display of canvases in jupyter notebooks Feb 19, 2024
@phsft-bot

Copy link
Copy Markdown

@phsft-bot

Copy link
Copy Markdown

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@github-actions

Copy link
Copy Markdown

Test Results

    12 files      12 suites   2d 1h 22m 5s ⏱️
 2 562 tests  2 561 ✅ 0 💤 1 ❌
28 822 runs  28 821 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit b488cef.

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants