Skip to content

[cmake] Make Minuit2 build option deprecation warning less alarming #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 2 commits into from
Feb 26, 2024
Merged

[cmake] Make Minuit2 build option deprecation warning less alarming #14814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
406afdf
[cmake] Make Minuit2 build option deprecation warning less alarming
ferdymercury Feb 24, 2024
c4489dd
[cmake] clarify wording of deprecate-OFF
ferdymercury Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmake/modules/RootBuildOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,15 +413,15 @@ foreach(opt afdsmgrd afs alien bonjour castor chirp cxx11 cxx14 cxx17 geocad gfa
endforeach()

#---Deprecated options------------------------------------------------------------------------
foreach(opt cxxmodules exceptions oracle pythia6 pythia6_nolink minuit2)
foreach(opt cxxmodules exceptions oracle pythia6 pythia6_nolink)
if(${opt})
message(DEPRECATION ">>> Option '${opt}' is deprecated and will be removed in the next release of ROOT. Please contact root-dev@cern.ch should you still need it.")
endif()
endforeach()

foreach(opt builtin_afterimage)
foreach(opt builtin_afterimage minuit2)
if(NOT ${opt})
message(DEPRECATION ">>> Option '${opt}' is deprecated and will be removed in the next release of ROOT. It should always be ON. Please contact root-dev@cern.ch should you still need it.")
message(DEPRECATION ">>> Option '${opt}' is deprecated: in the future it will always be set to ON. In the next release of ROOT, you will no longer be able to disable this feature. Please contact root-dev@cern.ch should you still need disabling it.")
endif()
endforeach()

Expand Down