Skip to content

[cmake] Make Minuit2 build option deprecation warning less alarming#14814

Merged
guitargeek merged 2 commits into
root-project:masterfrom
ferdymercury:minuit2
Feb 26, 2024
Merged

[cmake] Make Minuit2 build option deprecation warning less alarming#14814
guitargeek merged 2 commits into
root-project:masterfrom
ferdymercury:minuit2

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Feb 24, 2024

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

To avoid reports in the forum worrying about whether Minuit2 is gonna be removed.

See https://root-forum.cern.ch/t/will-minuit2-be-removed-from-root/58078

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

To avoid worry reports in the forum worrying about whether Minuit2 is gonna be removed.

See https://root-forum.cern.ch/t/will-minuit2-be-removed-from-root/58078
@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot

Copy link
Copy Markdown

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@github-actions

Copy link
Copy Markdown

Test Results

    12 files      12 suites   2d 3h 0m 26s ⏱️
 2 567 tests  2 565 ✅ 0 💤 2 ❌
28 858 runs  28 856 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit c4489dd.

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initiative! I will merge it and also take care of backporting it to the 6.30 branch, because this is where this commit makes sense.

@guitargeek guitargeek self-assigned this Feb 26, 2024
@guitargeek
guitargeek merged commit d4acc52 into root-project:master Feb 26, 2024
@ferdymercury
ferdymercury deleted the minuit2 branch February 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants