[ntuple] Some cleanups in the page source#22391
Open
jblomer wants to merge 7 commits into
Open
Conversation
The per-cluster/per-page OID mapping option was already unused (hard-coded). Going forward, the DAOS backend should only use the one-object-per-page option.
jblomer
force-pushed
the
ntuple-cleanup-loadpage
branch
from
5422338 to
26fff4b
Compare
pcanal
reviewed
May 23, 2026
| // clang-format on | ||
| class RPageSource : public RPageStorage { | ||
| protected: | ||
| /// Summarizes meta-data is necessary to load a certain page. Used by LoadPageImpl(). |
Member
There was a problem hiding this comment.
Suggested change
| /// Summarizes meta-data is necessary to load a certain page. Used by LoadPageImpl(). | |
| /// Summarizes meta-data that is necessary to load a certain page. Used by LoadPageImpl(). |
? or just meta-data necessary?
pcanal
reviewed
May 23, 2026
| /// Must not be called when the descriptor guard is taken. | ||
| void UpdateLastUsedCluster(ROOT::DescriptorId_t clusterId); | ||
|
|
||
| // Common treatment of zero pages that would otherwise needed to be handled in LoadPageImpl() |
Member
There was a problem hiding this comment.
Suggested change
| // Common treatment of zero pages that would otherwise needed to be handled in LoadPageImpl() | |
| // Common treatment of zero pages that would otherwise need to be handled in LoadPageImpl() |
Test Results 22 files 22 suites 3d 13h 13m 35s ⏱️ For more details on these failures, see this check. Results for commit 26fff4b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for huge-file support, some cleanup in the
RPageSourcefamily of classes.