Improve finalisation step of RNTuple Snapshot#22779
Merged
vepadulano merged 2 commits intoJul 9, 2026
Merged
Conversation
Aligning the implementation with the TTree Snapshot helper.
vepadulano
force-pushed
the
df-improve-ntuple-snapshot-finalize
branch
from
e78ada2 to
cd7d974
Compare
hageboeck
approved these changes
Jul 9, 2026
hageboeck
left a comment
hageboeck
left a comment
Member
There was a problem hiding this comment.
LGTM
Since the two commits touch the same line, you could squash on merge.
jblomer
approved these changes
Jul 9, 2026
Test Results 23 files 23 suites 3d 16h 36m 4s ⏱️ For more details on these failures, see this check. Results for commit cd7d974. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues found while testing #20272 on EOS