Skip to content

Improve finalisation step of RNTuple Snapshot #22779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vepadulano merged 2 commits into from
Jul 9, 2026
Merged

Improve finalisation step of RNTuple Snapshot #22779

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc074db
[df] Ensure proper writing of TFile in finalisation of RNTuple Snapshot
vepadulano Jul 9, 2026
cd7d974
[df] Use correct RNTuple name for top-level object
vepadulano Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tree/dataframe/src/RDFSnapshotHelpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,8 +971,13 @@ void ROOT::Internal::RDF::UntypedSnapshotRNTupleHelper::Finalize()
fFillContexts.clear();
// Then destroy the RNTupleParallelWriter and write the metadata.
fWriter.reset();
// Finally, close the output TFile to ensure it's properly written to disk. We don't destroy it to avoid triggering
// a warning about the lazy Snapshot not being triggered
fOutputFile->Close();

// We can now set the data source of the loop manager for the RDataFrame that is returned by the Snapshot call.
fOutputLoopManager->SetDataSource(std::make_unique<ROOT::RDF::RNTupleDS>(fDirName + "/" + fNTupleName, fFileName));
const auto fullNTupleName = fDirName.empty() ? fNTupleName : fDirName + '/' + fNTupleName;
fOutputLoopManager->SetDataSource(std::make_unique<ROOT::RDF::RNTupleDS>(fullNTupleName, fFileName));
}

/**
Expand Down
Loading