[WIP][PyROOT] Move interoperability functions to ROOT.Numpy namespace by stwunsch · Pull Request #5252 · root-project/root

stwunsch · 2020-03-30T17:05:46Z

The new namespace allows us to import libraries more lazily. Added a test that we load exactly the libraries that we expect.

phsft-bot · 2020-03-30T17:05:57Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-03-30T19:42:44Z

Build failed on ROOT-debian10-i386/cxx14.
See cdash See console output.

Failing tests:

projectroot.tree.treeplayer.test.gtest_tree_treeplayer_test_treeprocessormt

hageboeck

Shallow review OK, but leave for expert.

This allows us to inject dependencies associated with AsRVec lazily.

This allows us to inject TMVA and its dependencies fully lazily.

phsft-bot · 2020-03-31T13:53:31Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-03-31T14:16:11Z

Build failed on ROOT-fedora31/noimt.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-03-31T14:57:05Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-03-31T15:08:14Z

Build failed on ROOT-fedora31/noimt.
See cdash See console output.

Failing tests:

phsft-bot · 2020-03-31T15:17:43Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

phsft-bot · 2020-03-31T15:30:53Z

Build failed on ROOT-performance-centos7-multicore/default.
See cdash See console output.

Failing tests:

phsft-bot · 2020-03-31T15:37:56Z

Build failed on ROOT-fedora29/python3.
See cdash See console output.

Failing tests:

phsft-bot · 2020-03-31T15:39:18Z

Build failed on ROOT-ubuntu16/nortcxxmod.
See cdash See console output.

Failing tests:

phsft-bot · 2020-03-31T16:05:56Z

Build failed on ROOT-fedora30/cxx14.
See cdash See console output.

Failing tests:

phsft-bot · 2020-03-31T16:43:40Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-03-31T16:54:06Z

Build failed on ROOT-fedora31/noimt.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-03-31T17:12:48Z

Build failed on ROOT-fedora29/python3.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-03-31T17:19:14Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-03-31T17:42:23Z

Build failed on ROOT-performance-centos7-multicore/default.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-03-31T17:48:41Z

Build failed on windows10/cxx14.
See cdash See console output.

phsft-bot · 2020-03-31T18:09:41Z

Build failed on ROOT-fedora30/cxx14.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-01T07:55:31Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-04-01T08:08:59Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-04-01T08:24:34Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

hageboeck

Shallow review looks ok. Maybe the commit message of #5 is a bit too generic if you don't know what the 4 previous commits were.

phsft-bot · 2020-04-01T08:42:59Z

Build failed on ROOT-fedora30/cxx14.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-01T08:43:55Z

Build failed on ROOT-performance-centos7-multicore/default.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-01T08:45:42Z

Build failed on ROOT-ubuntu16/nortcxxmod.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-01T09:10:21Z

Build failed on ROOT-debian10-i386/cxx14.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-01T09:11:30Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-04-01T09:53:38Z

Build failed on windows10/cxx14.
See cdash See console output.

Errors:

[2020-04-01T09:53:36.366Z] CMake Error at cmake/modules/SearchRootCoreDeps.cmake:52 (if):
[2020-04-01T09:53:36.366Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:941 (message):

phsft-bot · 2020-04-01T10:28:20Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-01T11:01:24Z

Build failed on ROOT-performance-centos7-multicore/default.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

stwunsch · 2020-04-02T07:05:49Z

@phsft-bot build

phsft-bot · 2020-04-02T07:05:57Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-04-02T07:23:20Z

Build failed on ROOT-performance-centos7-multicore/default.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-02T07:26:23Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-02T13:18:28Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-04-02T13:19:52Z

Build failed on windows10/cxx14.
See cdash See console output.

Errors:

[2020-04-02T13:19:50.809Z] CMake Error at cmake/modules/SearchRootCoreDeps.cmake:52 (if):
[2020-04-02T13:19:51.337Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:941 (message):

phsft-bot · 2020-04-02T15:20:27Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

phsft-bot · 2020-04-03T06:58:39Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2020-04-03T07:34:58Z

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

projectroot.bindings.pyroot_experimental.pythonizations.test.pyunittests_pyroot_import_load_libs

stwunsch · 2020-04-03T08:17:34Z

Going to be replaced by #5285. I keep this one a little longer around to figure out which libraries we load on mac.

stwunsch requested a review from etejedor March 30, 2020 17:05

stwunsch self-assigned this Mar 30, 2020

hageboeck reviewed Mar 31, 2020

View reviewed changes

stwunsch mentioned this pull request Mar 31, 2020

[WIP][PyROOT] Add test checking loaded libraries after import #5256

Closed

stwunsch added 2 commits March 31, 2020 15:44

[PyROOT] Move AsRVec to ROOT.Numpy

5eaff21

This allows us to inject dependencies associated with AsRVec lazily.

[PyROOT] Move AsRTensor to ROOT.Numpy

cf28cab

This allows us to inject TMVA and its dependencies fully lazily.

stwunsch force-pushed the numpy-asrvec branch from 5a4d9de to ede22f2 Compare March 31, 2020 13:53

stwunsch requested a review from oshadura as a code owner March 31, 2020 13:53

stwunsch force-pushed the numpy-asrvec branch from ede22f2 to ca3e60d Compare March 31, 2020 14:56

stwunsch changed the title ~~[WIP][PyROOT] Move AsRVec to ROOT.Numpy~~ [WIP][PyROOT] Move interoperability functions to ROOT.Numpy namespace Mar 31, 2020

[PyROOT] Move MakeNumpyDataFrame to Numpy.Experimental.MakeDataFrame

f2afd11

stwunsch force-pushed the numpy-asrvec branch from ca3e60d to 616ae94 Compare March 31, 2020 16:43

stwunsch force-pushed the numpy-asrvec branch from 81612a7 to a59849d Compare April 1, 2020 07:55

stwunsch force-pushed the numpy-asrvec branch from a59849d to 4aac0f8 Compare April 1, 2020 08:08

root-project deleted a comment from phsft-bot Apr 1, 2020

hageboeck reviewed Apr 1, 2020

View reviewed changes

stwunsch force-pushed the numpy-asrvec branch from 4aac0f8 to f7b9b2f Compare April 1, 2020 09:11

stwunsch force-pushed the numpy-asrvec branch from f7b9b2f to d3c4d5a Compare April 2, 2020 13:18

[PyROOT] Add test checking loaded libraries after import

4ac7d2f

stwunsch force-pushed the numpy-asrvec branch from d3c4d5a to 4ac7d2f Compare April 3, 2020 06:58

stwunsch closed this Apr 3, 2020

Uh oh!

Conversation

stwunsch commented Mar 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phsft-bot commented Mar 30, 2020

Uh oh!

phsft-bot commented Mar 30, 2020

Failing tests:

Uh oh!

hageboeck left a comment

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Mar 31, 2020

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Mar 31, 2020

Uh oh!

phsft-bot commented Mar 31, 2020

Failing tests:

Uh oh!

phsft-bot commented Apr 1, 2020

Uh oh!

phsft-bot commented Apr 1, 2020

Uh oh!

phsft-bot commented Apr 1, 2020

Failing tests:

Uh oh!

hageboeck left a comment

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Apr 1, 2020

Failing tests:

Uh oh!

phsft-bot commented Apr 1, 2020

Failing tests:

Uh oh!

phsft-bot commented Apr 1, 2020

Failing tests:

Uh oh!

phsft-bot commented Apr 1, 2020

Failing tests:

Uh oh!

phsft-bot commented Apr 1, 2020

stwunsch commented Mar 30, 2020 •

edited

Loading