Skip to content

[PyROOT] Make namespace pythonizations lazy#5285

Merged
etejedor merged 2 commits into
root-project:masterfrom
stwunsch:pyroot-numpy
Apr 7, 2020
Merged

[PyROOT] Make namespace pythonizations lazy#5285
etejedor merged 2 commits into
root-project:masterfrom
stwunsch:pyroot-numpy

Conversation

@stwunsch

@stwunsch stwunsch commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

Implementing the suggestions from yesterdays PPP meeting

@stwunsch
stwunsch requested a review from etejedor April 3, 2020 08:15
@stwunsch
stwunsch requested a review from oshadura as a code owner April 3, 2020 08:15
@stwunsch stwunsch self-assigned this Apr 3, 2020
@phsft-bot

phsft-bot commented Apr 3, 2020

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

stwunsch
stwunsch commented Apr 3, 2020
View reviewed changes
Comment thread bindings/pyroot_experimental/pythonizations/python/ROOT/_facade.py Outdated
@stwunsch stwunsch mentioned this pull request Apr 3, 2020
Closed
@phsft-bot

phsft-bot commented Apr 3, 2020

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

phsft-bot commented Apr 3, 2020

Copy link
Copy Markdown

Build failed on mac1015/cxx17.
See cdash See console output.

Failing tests:

@stwunsch

stwunsch commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

Regarding the failing test on mac: mac just imports stuff ... i'll track down whether it's us or pulled in by the system.

etejedor
etejedor reviewed Apr 6, 2020
View reviewed changes
Comment thread bindings/pyroot_experimental/pythonizations/python/ROOT/_facade.py Outdated
etejedor
etejedor reviewed Apr 6, 2020
View reviewed changes
Comment thread bindings/pyroot_experimental/pythonizations/python/ROOT/_facade.py Outdated
etejedor
etejedor reviewed Apr 6, 2020
View reviewed changes
Comment thread bindings/pyroot_experimental/pythonizations/python/ROOT/_facade.py Outdated
@stwunsch stwunsch mentioned this pull request Apr 7, 2020
Merged
@phsft-bot

phsft-bot commented Apr 7, 2020

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

phsft-bot commented Apr 7, 2020

Copy link
Copy Markdown

Build failed on mac1015/cxx17.
See cdash .
See console output.

Failing tests:

@phsft-bot

phsft-bot commented Apr 7, 2020

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

etejedor
etejedor reviewed Apr 7, 2020
View reviewed changes
Comment thread bindings/pyroot_experimental/pythonizations/test/CMakeLists.txt Outdated
@phsft-bot

phsft-bot commented Apr 7, 2020

Copy link
Copy Markdown

Build failed on mac1015/cxx17.
See cdash .
See console output.

Failing tests:

@phsft-bot

phsft-bot commented Apr 7, 2020

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

stwunsch added 2 commits April 7, 2020 11:59
@stwunsch
[PyROOT] Add test checking loaded libraries after import
fcd4bca
@stwunsch
[PyROOT] Make namespace pythonizations lazy
40d33a8 
* Remove dependency on VecOps, RDataFrame and TMVA for import ROOT
* Inject namespace overload via property in the ROOT facade
* Take care that we have proper error handling if, e.g., TMVA is not
  there
@phsft-bot

phsft-bot commented Apr 7, 2020

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1015/cxx17, windows10/cxx14
How to customize builds

@stwunsch stwunsch changed the title [WIP][PyROOT] Make namespace pythonizations lazy [PyROOT] Make namespace pythonizations lazy Apr 7, 2020
@stwunsch

stwunsch commented Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

@etejedor Go go go! :)

etejedor
etejedor approved these changes Apr 7, 2020
View reviewed changes

@etejedor etejedor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, @stwunsch !

@etejedor
etejedor merged commit fbbd72f into root-project:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oshadura oshadura Awaiting requested review from oshadura
1 more reviewer
@etejedor etejedor etejedor approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stwunsch stwunsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stwunsch @phsft-bot @etejedor