Open
Conversation
Fixes a bug where 0 is not a legal input and defaults to 60 seconds. However 0 should symbolize an infinite long timeout according to the documentation: https://cmake.org/cmake/help/latest/prop_test/TIMEOUT.html Tested on Ubuntu 22.04.5 LTS (Linux 6.8.0-107-generic) Background: Basically the halting problem. You sometimes do not know how long something might take. And since we are building robots we want to do integration tests that may take very long. NOTE: this is wrong since at least humble but I am too stupid to merge it across branches SECOND NOTE: This bug is dragged trough https://github.com/ament/ament_cmake, I made a second pull request for that too. THIRD NOTE: No AI was used for this pullrequest (hence the typos) Signed-off-by: fprott <florianprott@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where 0 is not a legal input and defaults to 60 seconds. However 0 should symbolize an infinite long timeout according to the documentation: https://cmake.org/cmake/help/latest/prop_test/TIMEOUT.html
This is especially important for robotics since some tests let you run into the halting problem. So you do not know how long it takes. Example: optimization
Is this user-facing behavior change?
Kind of. This should not break existing test cases but this corrects the expectation that a TIMEOUT 0 means that the tests run indefinitely. So it gets rid of the hard to spot bugs that happen only when you have tests that should run over 60 sec.
Did you use Generative AI?
No AI was used (hence the typos)
Additional Information
Tested on Ubuntu 22.04.5 LTS (Linux 6.8.0-107-generic) using ROS 2 humble
This bug is dragged trough https://github.com/ament/ament_cmake, I made a second pull request for that too. The changes will not go into affect till they merge this in.
See: ament/ament_cmake#623 (comment)