docs: Document outbound passthrough policy and route-based token exchange#190
Merged
pdettori merged 1 commit intoMar 11, 2026
Merged
Conversation
mrsabath
force-pushed
the
docs/authbridge-testing-knowledge
branch
from
March 11, 2026 00:42
d39fcd2 to
5c7ab24
Compare
pdettori
approved these changes
Mar 11, 2026
pdettori
left a comment
Member
There was a problem hiding this comment.
Review Summary
Clean docs update capturing operational knowledge from the passthrough-by-default outbound model (#188). Well-structured route resolver docs and valuable new gotchas.
Areas reviewed: Docs/Markdown (2 files, ~47 additions/~41 deletions)
Commits: 1 commit, signed-off with correct Assisted-By attribution
CI: CI Checks pass, DCO pass
Highlights
- Route resolver section clearly explains host matching semantics and
filepath.Matchbehavior - Gotchas #7-8 (passthrough default, short service names) will save debugging time
- Separating
keycloak-admin-secretfromenvironmentsin the resource table is a good accuracy improvement
Items to verify (non-blocking)
routes.yamlformat — The example now shows aroutes:top-level key wrapping the list. The old format was a bare YAML list. Verify this matches the actual go-processor parsing — if the code expects a bare list, this example would be misleading.- Default path — Changed from
/etc/authproxy/routes.yamlto/etc/authproxy-routes/routes.yaml. Confirm this matches the actual ConfigMap mount path. SPIRE_ENABLEDkey — TheenvironmentsConfigMap lostSPIRE_ENABLEDfrom its key fields in the table. If still a valid key, consider keeping it.
…ange Update CLAUDE.md files to reflect the new passthrough-by-default outbound model and authproxy-routes ConfigMap. Add documentation for: - authproxy-routes ConfigMap format and per-host token exchange rules - keycloak-admin-secret Secret (separated from environments ConfigMap) - DEFAULT_OUTBOUND_POLICY and ROUTES_CONFIG_PATH env vars - Route resolver behavior and host pattern matching - Three new gotchas: host pattern matching with HTTP Host headers, Keycloak scope assignment for dynamically registered clients, and outbound passthrough as the safe default Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Mariusz Sabath <mrsabath@gmail.com>
mrsabath
force-pushed
the
docs/authbridge-testing-knowledge
branch
from
March 11, 2026 02:30
5c7ab24 to
d3700db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdandAuthBridge/CLAUDE.mdto reflect the passthrough-by-default outbound model introduced in fix: Correct authproxy-routes host pattern and add Keycloak scope ass… #188authproxy-routesConfigMap format for per-host token exchange ruleskeycloak-admin-secretSecret from theenvironmentsConfigMap in the runtime resource tablesDEFAULT_OUTBOUND_POLICYandROUTES_CONFIG_PATHenvironment variable documentationRelates to #185
Test plan
authproxy-routesusage in demos