Fix dropdown button knobs not working#79
Conversation
…cript.React.Components into main
…cript.React.Components into main
…cript.React.Components into main
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 29.96% 30.70% +0.74%
==========================================
Files 51 51
Lines 901 902 +1
Branches 209 209
==========================================
+ Hits 270 277 +7
+ Misses 625 623 -2
+ Partials 6 2 -4
Continue to review full report at Codecov.
|
|
|
||
| if (size != null) { | ||
| classNames.push(size); | ||
| classNames.push(`-${size}`); |
There was a problem hiding this comment.
Were the ButtonSize and ButtonStyle enums changed? Just curious about this - not saying it should change back, if so. I believe we have been trying to move away from coupling the class name to the enum representation
There was a problem hiding this comment.
No the ButtonSize and ButtonStyle enums were not changed. They are being used in many places but the issue was all the other places were using (-${size}) as opposed to (size), and same goes for style. That is also how they are being given styles through the CSS.



Closes #50