Skip to content

Fix dropdown button knobs not working#79

Merged
brandongregoryscott merged 4 commits into
rsm-hcd:mainfrom
SaidShah:fix-dropdown-button-knobs-not-working
Nov 7, 2020
Merged

Fix dropdown button knobs not working#79
brandongregoryscott merged 4 commits into
rsm-hcd:mainfrom
SaidShah:fix-dropdown-button-knobs-not-working

Conversation

@SaidShah
Copy link
Copy Markdown
Contributor

@SaidShah SaidShah commented Nov 4, 2020

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

Closes #50

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 4, 2020

Codecov Report

Merging #79 into main will increase coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   29.96%   30.70%   +0.74%     
==========================================
  Files          51       51              
  Lines         901      902       +1     
  Branches      209      209              
==========================================
+ Hits          270      277       +7     
+ Misses        625      623       -2     
+ Partials        6        2       -4     
Impacted Files Coverage Δ
src/atoms/buttons/button.tsx 100.00% <ø> (ø)
src/molecules/dropdown-button/dropdown-button.tsx 100.00% <100.00%> (ø)
src/molecules/form-fields/input-form-field.tsx 100.00% <100.00%> (+31.25%) ⬆️
src/atoms/forms/select.tsx 100.00% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b41b8...c50e382. Read the comment docs.


if (size != null) {
classNames.push(size);
classNames.push(`-${size}`);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the ButtonSize and ButtonStyle enums changed? Just curious about this - not saying it should change back, if so. I believe we have been trying to move away from coupling the class name to the enum representation

Copy link
Copy Markdown
Contributor Author

@SaidShah SaidShah Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the ButtonSize and ButtonStyle enums were not changed. They are being used in many places but the issue was all the other places were using (-${size}) as opposed to (size), and same goes for style. That is also how they are being given styles through the CSS.

@brandongregoryscott
Copy link
Copy Markdown
Contributor

Pulled it down & gave it a whirl - the described issue is fixed, but we may need to revisit the actual styles. The dropdown looks a bit silly in pretty much every state -

  • Small
    image
  • Medium
    image
  • Large
    image

@brandongregoryscott brandongregoryscott merged commit 6648d7d into rsm-hcd:main Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Knobs for Dropdown button not working in storybook

2 participants