Skip to content

Fix dropdown button knobs not working #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandongregoryscott merged 4 commits into from
Nov 7, 2020
Merged

Fix dropdown button knobs not working #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
890dabd
Merge branch 'main' of github.com:AndcultureCode/AndcultureCode.JavaS…
Nov 3, 2020
980ebce
Merge branch 'main' of github.com:AndcultureCode/AndcultureCode.JavaS…
Nov 4, 2020
1261a08
Merge branch 'main' of github.com:AndcultureCode/AndcultureCode.JavaS…
Nov 4, 2020
c50e382
Updated dropdown button size and style classes and fixed tests
Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/molecules/dropdown-button/dropdown-button.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe("DropdownButton", () => {
size={testButtonSize}
/>
);
const result = container.getElementsByClassName(testButtonSize);
const result = container.getElementsByClassName(`-${testButtonSize}`);

// Assert
expect(result).toHaveLength(1);
Expand All @@ -75,7 +75,7 @@ describe("DropdownButton", () => {
style={testButtonStyle}
/>
);
const result = container.getElementsByClassName(testButtonStyle);
const result = container.getElementsByClassName(`-${testButtonStyle}`);

// Assert
expect(result).toHaveLength(1);
Expand Down
4 changes: 2 additions & 2 deletions src/molecules/dropdown-button/dropdown-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ const DropdownButton: React.FC<DropdownButtonProps> = (
}

if (size != null) {
classNames.push(size);
classNames.push(`-${size}`);
Copy link
Copy Markdown
Contributor

@brandongregoryscott brandongregoryscott Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the ButtonSize and ButtonStyle enums changed? Just curious about this - not saying it should change back, if so. I believe we have been trying to move away from coupling the class name to the enum representation

Copy link
Copy Markdown
Contributor Author

@SaidShah SaidShah Nov 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the ButtonSize and ButtonStyle enums were not changed. They are being used in many places but the issue was all the other places were using (-${size}) as opposed to (size), and same goes for style. That is also how they are being given styles through the CSS.

}

if (style != null) {
classNames.push(style);
classNames.push(`-${style}`);
}

return (
Expand Down