[PoC] Support dialog theme/color configuration#380
Closed
st0012 wants to merge 2 commits intoruby:masterfrom
Closed
[PoC] Support dialog theme/color configuration#380st0012 wants to merge 2 commits intoruby:masterfrom
st0012 wants to merge 2 commits intoruby:masterfrom
Conversation
Member
Author
Member
peterzhu2118
left a comment
peterzhu2118
left a comment
There was a problem hiding this comment.
👍 I like having themes. Makes the UX better.
This was referenced Jul 24, 2022
Merged
st0012
force-pushed
the
support-dialog-color-configuration
branch
from
a96074f to
3a44f1c
Compare
st0012
force-pushed
the
support-dialog-color-configuration
branch
from
3a44f1c to
81a3583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://bugs.ruby-lang.org/issues/19010
Todos
If we want to proceed on this idea, we have the following todos:
reline 0.4.0for the new APIsrelinerequirement and drop Ruby 2.5 support becauserelinenow requires 2.6+