Add latest version of reline into test matrix#381
Conversation
| jobs: | ||
| irb: | ||
| name: irb (${{ matrix.ruby }} / ${{ matrix.os }}) | ||
| name: rake test ${{ matrix.ruby }} ${{ matrix.with_latest_reline && '(latest reline)' || '' }} |
There was a problem hiding this comment.
We only run against ubuntu-latest so I think it's not necessary to indicate that in job names.
| os: [ubuntu-latest] | ||
| with_latest_reline: [true, false] | ||
| exclude: | ||
| - ruby: '2.5' |
There was a problem hiding this comment.
I plan to drop the support of Ruby 2.5 because it won't be supported by the next reline release.
There was a problem hiding this comment.
We can probably drop support for 2.6 and earlier completely since they aren't supported Rubies anymore.
There was a problem hiding this comment.
I don't mind keeping 2.6 available until the day we need to make workaround for it
There was a problem hiding this comment.
We can probably completely drop support for 2.5, it EOL'd in March 2021, almost 1.5 years ago.
There was a problem hiding this comment.
It requires other changes like gemspec so I’ll drop it in another PR 👍
| os: [ubuntu-latest] | ||
| with_latest_reline: [true, false] | ||
| exclude: | ||
| - ruby: '2.5' |
There was a problem hiding this comment.
We can probably drop support for 2.6 and earlier completely since they aren't supported Rubies anymore.
st0012
force-pushed
the
test-with-latest-reline
branch
from
c645912 to
f05f071
Compare
2 participants
When adopting newest reline features (e.g. #380), I find it hard to know what failures are caused by the
relineupgrade and what's caused by the code change. Example build.And if we make the CI to run against the latest
reline, we will lose the coverage on currently releasedrelineversion.So I think we can make the CI run with both "latest release" and "master" to make such changes easier and safer.