Date validations to prevent invalid dates like 6/1/20000#5806
Merged
Conversation
Co-authored-by: Yellewwossen Moghes <yellewwossen@gmail.com>
Co-authored-by: Yellewwossen Moghes <yellewwossen@gmail.com>
Co-authored-by: Yellewwossen Moghes <yellewwossen@gmail.com>
Collaborator
|
looks great, please fix failing tests and then we can merge :) |
elasticspoon
approved these changes
Jun 6, 2024
Collaborator
elasticspoon
left a comment
There was a problem hiding this comment.
LGTM.
Just a thought (don't actually change anything in response to this) I wonder if a better arbitrary date instead of 1989 should have been 22 years ago (I think 21 years is the cap on age in foster care).
Collaborator
|
24 days cap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5646
What changed, and why?
Added date validations to avoid bad dates like 6/1/20000:
CourtDate
CasaCase
CaseContact
LearningHour
MileageRate
OtherDuties
PlacementsStartedAt
User
UserReminderTime - added by #3735 but not used anywhere. Currently no orgs use SMS anyways so we are fine ignoring this
case_contact_types —> ignored
no_contact_made —> ignored
How is this tested? (please write tests!) 💖💪
Updated specs for models and manually tested UI.
Screenshots please :)
Sample validation for new court dates:

Feelings gif (optional)
😀 😀

Worked on by @yyelleww70 and @marc .