#1796: "try again"! reminder for volunteers after no contact made#3735
Merged
Conversation
Collaborator
Author
|
Apologies for the number of file changes. Had to rename a table and thus change references in a bunch of places. This should simplify keeping track of reminder times tho. Also abstracted out a service which dries up a lot of the sms reminders code. |
7riumph
reviewed
Jul 3, 2022
compwron
approved these changes
Jul 4, 2022
Collaborator
compwron
left a comment
There was a problem hiding this comment.
hopefully the migrations go well in qa- should be fine in prod.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #1796
What changed, and why?
user_case_contact_types_remindertable to beuser_reminder_timewhere each column now represents time a reminder was last sent (simpler this way)sms_reminder_serviceto be used by other reminder services such as thisno_contact_reminderand previously createdcourt_date_report_due_reminderHow will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
N/A