Skip to content

#1796: "try again"! reminder for volunteers after no contact made#3735

Merged
compwron merged 16 commits into
rubyforgood:mainfrom
harsohailB:feature/1796
Jul 4, 2022
Merged

#1796: "try again"! reminder for volunteers after no contact made#3735
compwron merged 16 commits into
rubyforgood:mainfrom
harsohailB:feature/1796

Conversation

@harsohailB
Copy link
Copy Markdown
Collaborator

@harsohailB harsohailB commented Jul 2, 2022

What github issue is this PR for, if any?

Resolves #1796

What changed, and why?

  • Updated user_case_contact_types_reminder table to be user_reminder_time where each column now represents time a reminder was last sent (simpler this way)
  • Created service and task for sending out no contact made reminders (tasks runs daily)
  • Abstracted out sms_reminder_service to be used by other reminder services such as this no_contact_reminder and previously created court_date_report_due_reminder

How will this affect user permissions?

  • Volunteer permissions: N/A
  • Supervisor permissions: N/A
  • Admin permissions: N/A

How is this tested? (please write tests!) 💖💪

  • Wrote tests for model, service, and task added

Screenshots please :)

N/A

@harsohailB
Copy link
Copy Markdown
Collaborator Author

harsohailB commented Jul 2, 2022

Apologies for the number of file changes. Had to rename a table and thus change references in a bunch of places. This should simplify keeping track of reminder times tho. Also abstracted out a service which dries up a lot of the sms reminders code.

@harsohailB harsohailB requested a review from compwron July 2, 2022 23:30
@harsohailB harsohailB added the codethechange code.the.change developers label Jul 2, 2022
@harsohailB harsohailB requested review from 7riumph and xihai01 July 2, 2022 23:30
@harsohailB harsohailB marked this pull request as ready for review July 2, 2022 23:30
Comment thread app/services/court_report_due_sms_reminder_service.rb Outdated
@harsohailB harsohailB requested a review from 7riumph July 4, 2022 00:14
Copy link
Copy Markdown
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully the migrations go well in qa- should be fine in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codethechange code.the.change developers ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"try again"! reminder for volunteers after no contact made

3 participants