Add waitforblock, waitforblockheight and waitfornewblock - #388
Merged
Conversation
jamillambert
force-pushed
the
1016-wait-for-block
branch
from
October 16, 2025 07:56
cbfde5b to
2edb0b5
Compare
jamillambert
marked this pull request as draft
October 16, 2025 07:56
Collaborator
Author
|
Converting to draft to fix CI test fail that does not happen locally. Actually it does occur locally, I only checked 17 and 30. For some reason only v23-26 fail. Update: Problem fixed, although I don't understand why it only affected v23-26. |
jamillambert
force-pushed
the
1016-wait-for-block
branch
from
October 16, 2025 08:08
2edb0b5 to
6a684dc
Compare
jamillambert
marked this pull request as ready for review
October 16, 2025 08:15
Collaborator
Author
|
The three RPCs have the same return shape. I made 3 seperate types since they only have a block hash and height in them it made no sense to have a seperate internal type that only has those 2 values in it. I considered having one type e.g. |
Member
|
Needs rebase please mate. |
The hidden module had a copy-paste error and stated it was for the generating section. Update the documentation to state that the methods are hidden and not shown in the COre API docs.
blockchain__get_tx_out_proof__modelled is identical to blockchain__verify_tx_out_proof__modelled, and the method gettxoutproof is tested above in blockchain__get_tx_out_proof. Remove the redundant test.
The model part of the verify_tx_out_proof test was in it's own function that the test function called. Other tests all check the model in the same test. Combine them into one function. Place it in the correct location. Remove associated import.
Add waitforblock, waitforblockheight and waitfornewblock methods to v17. They are hidden until v30 with no changes.
jamillambert
force-pushed
the
1016-wait-for-block
branch
from
October 27, 2025 10:01
6a684dc to
8b0a914
Compare
Collaborator
Author
|
Rebased |
tcharding
approved these changes
Oct 27, 2025
This was referenced Nov 7, 2025
tcharding
added a commit
that referenced
this pull request
Nov 9, 2025
2343534 Update listwalletdir for v30 changes (Jamil Lambert, PhD) cb73a83 Update getwalletinfo for v30 changes (Jamil Lambert, PhD) 86c40a4 Document that migratewallet is untested in v30 (Jamil Lambert, PhD) 4dbd863 Add deprecated flag to v30 settxfee test (Jamil Lambert, PhD) Pull request description: There are four remaining RPCs that have changes in v30 that need to be implemented: - `settxfee` is deprecated in v30 and removed in v31. Feature gate the test to v30 and below and for v30 add the required `-deprecatedrpc=settxfee` flag. Remove TODO from the types table. - In v30 it is no longer possible to create a legacy wallet. This means that `migratewallet` cannot be tested using only v30. There are no changes to the RPC in v30 so the v29 test is still valid. Add a comment to the types table and test. - `getwalletinfo` had some return fields removed in v30 and a new flags field was added. Update the model to make the removed fields options and add the new flags. Update all the into functions. Redefine the type, error and into function for v30. Remove the TODO from the types table. Remove the `v29_and_below` feature gate from the test. - `listwalletdir` has a new `warnings` field was added in v30. Redefine the type for v30, there is no model. Remove the TODO from the types table. Remove the `v29_and_below` feature gate from the test. Together with #387, #388, #409 and #410 Closes #384 ACKs for top commit: tcharding: ACK 2343534 Tree-SHA512: 788e6150778dc722c7db79e63240d4c82d3ceca59ec859edd516d1ea8860671754be3072f4b5bdd391dac919bba6a61935c99df4bb3b4325cf981271ef4e87bf
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitforblock,waitforblockheightandwaitfornewblockwere added to the Core API docs in v30 under blockchain. The RPCs have been there since before v17.Add the RPCs to v17, and add to the types table in v30.
generatingsection.hidden.blockchain__get_tx_out_proof__modelledis identical toblockchain__verify_tx_out_proof__modelled, and the methodgettxoutproofis tested above inblockchain__get_tx_out_proof.verify_tx_out_prooftest was in it's own function that the test function called. Other tests all check the model in the same test.waitforblock,waitforblockheightandwaitfornewblockmethods to v17. They are hidden until v30 with no changes.