Implement v30 changes to decodepsbt RPC - #410
Merged
Merged
Conversation
Collaborator
Author
|
This is a Draft to get feedback on the way it has been done, and the merge conflicts which will come after #409 goes in.
|
Member
|
This approach seems like a good one. Perhaps add a comment to the |
jamillambert
force-pushed
the
1103-v30-decodepsbt
branch
from
November 5, 2025 19:32
8b047f1 to
08ff106
Compare
Reexport the errors from v17 for later versions instead of importing from `crate::v17`. Reexport the new version of the errors from v24 in later versions. Reorginazation only, no functional changes.
Copy the raw_transactions folder from v24 to v30 and update exports. No other changes.
Add the new MuSig2 fields in decodepsbt.
jamillambert
force-pushed
the
1103-v30-decodepsbt
branch
from
November 5, 2025 19:45
08ff106 to
05af218
Compare
Collaborator
Author
|
Added a comment to |
jamillambert
marked this pull request as ready for review
November 5, 2025 19:47
tcharding
approved these changes
Nov 5, 2025
This was referenced Nov 7, 2025
tcharding
added a commit
that referenced
this pull request
Nov 9, 2025
2343534 Update listwalletdir for v30 changes (Jamil Lambert, PhD) cb73a83 Update getwalletinfo for v30 changes (Jamil Lambert, PhD) 86c40a4 Document that migratewallet is untested in v30 (Jamil Lambert, PhD) 4dbd863 Add deprecated flag to v30 settxfee test (Jamil Lambert, PhD) Pull request description: There are four remaining RPCs that have changes in v30 that need to be implemented: - `settxfee` is deprecated in v30 and removed in v31. Feature gate the test to v30 and below and for v30 add the required `-deprecatedrpc=settxfee` flag. Remove TODO from the types table. - In v30 it is no longer possible to create a legacy wallet. This means that `migratewallet` cannot be tested using only v30. There are no changes to the RPC in v30 so the v29 test is still valid. Add a comment to the types table and test. - `getwalletinfo` had some return fields removed in v30 and a new flags field was added. Update the model to make the removed fields options and add the new flags. Update all the into functions. Redefine the type, error and into function for v30. Remove the TODO from the types table. Remove the `v29_and_below` feature gate from the test. - `listwalletdir` has a new `warnings` field was added in v30. Redefine the type for v30, there is no model. Remove the TODO from the types table. Remove the `v29_and_below` feature gate from the test. Together with #387, #388, #409 and #410 Closes #384 ACKs for top commit: tcharding: ACK 2343534 Tree-SHA512: 788e6150778dc722c7db79e63240d4c82d3ceca59ec859edd516d1ea8860671754be3072f4b5bdd391dac919bba6a61935c99df4bb3b4325cf981271ef4e87bf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decodepsbtadds new musig fields in v30. These cannot be currently modelled withrust-bitcointypes and this PR does not change the model type. (rust-bitcoin/rust-bitcoin#4207).The error types from v17 were not reexported and instead imported by referencing the v17 module in the import statement.
superinstead ofcrate::v17.decodepsbtand all the related sub types and errors from v24 to v30. This patch copies to code and updates the exports only.