Skip to content

Provide v2_compat for ToggleableOutputPin#138

Merged
bors[bot] merged 1 commit into
rust-embedded:masterfrom
little-arhat:master
May 14, 2019
Merged

Provide v2_compat for ToggleableOutputPin#138
bors[bot] merged 1 commit into
rust-embedded:masterfrom
little-arhat:master

Conversation

@little-arhat

@little-arhat little-arhat commented May 12, 2019

Copy link
Copy Markdown
Contributor

fixes #137

@little-arhat little-arhat requested review from a team, ilya-epifanov and thejpster as code owners May 12, 2019 17:20
@rust-highfive

rust-highfive commented May 12, 2019

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @hannobraun (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

ryankurte
ryankurte previously approved these changes May 13, 2019
View reviewed changes

@ryankurte ryankurte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@hannobraun

hannobraun commented May 13, 2019

Copy link
Copy Markdown
Member

bors r=ryankurte

bors Bot added a commit that referenced this pull request May 13, 2019
@bors @little-arhat
Merge #138
820c5e4 
138: Provide v2_compat for ToggleableOutputPin r=ryankurte a=little-arhat

fixes #137

Co-authored-by: Roma Sokolov <sokolov.r.v@gmail.com>
@bors

bors Bot commented May 13, 2019

Copy link
Copy Markdown
Contributor

Build failed

@little-arhat

little-arhat commented May 13, 2019

Copy link
Copy Markdown
Contributor Author

Fixed tests.

@little-arhat

little-arhat commented May 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bors[bot] r?

bors r?

*  bors Expected — Waiting for status to be reported 
*  continuous-integration/travis-ci/pr — The Travis CI build passed

hm

@little-arhat

little-arhat commented May 14, 2019

Copy link
Copy Markdown
Contributor Author

@hannobraun @ilya-epifanov @thejpster do you have any objections to merging this?

@ryankurte

ryankurte commented May 14, 2019

Copy link
Copy Markdown
Contributor

bors r+

@bors

bors Bot commented May 14, 2019

Copy link
Copy Markdown
Contributor

👎 Rejected by too few approved reviews

@ryankurte

ryankurte commented May 14, 2019

Copy link
Copy Markdown
Contributor

bors r+

bors Bot added a commit that referenced this pull request May 14, 2019
@bors @little-arhat
Merge #138
b2bbae4 
138: Provide v2_compat for ToggleableOutputPin r=ryankurte a=little-arhat

fixes #137

Co-authored-by: Roma Sokolov <sokolov.r.v@gmail.com>
@bors

bors Bot commented May 14, 2019

Copy link
Copy Markdown
Contributor

Build succeeded

@bors bors Bot merged commit c91e84e into rust-embedded:master May 14, 2019
@eldruin eldruin mentioned this pull request May 27, 2020
Merged
bors Bot added a commit that referenced this pull request May 27, 2020
@bors @eldruin
Merge #214
3ea6b64 
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin

This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
bors Bot added a commit that referenced this pull request Jun 10, 2020
@bors @eldruin
Merge #214
4c07da5 
214: [0.2.x]: Fix warning, remove #[deny(warnings)] but keep check on CI r=ryankurte a=eldruin

This fixes #213. Additionally I removed #[deny(warnings)] but added a check for it on CI.
I think we should cherry pick #138 to the 0.2.x branch as well and release a 0.2.4 version, since 1.0 will still take a while.
I can do that in a separate PR.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@eldruin eldruin mentioned this pull request Jun 10, 2020
Merged
bors Bot added a commit that referenced this pull request Jun 10, 2020
@bors @little-arhat
@ryankurte @eldruin
Merge #220
20fad3e 
220: [0.2.x] Fixes to digital compatibility shim r=ryankurte a=eldruin

I cherry-picked #138 and some improvements to docs and included #199.

Co-authored-by: Roma Sokolov <sokolov.r.v@gmail.com>
Co-authored-by: Ryan Kurte <ryankurte@gmail.com>
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankurte ryankurte ryankurte approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

@thejpster thejpster Awaiting requested review from thejpster

Assignees

@hannobraun hannobraun

Labels

S-waiting-on-review Review is incomplete T-hal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2_compat does not provide shims for ToggleableOutputPin

4 participants

@little-arhat @rust-highfive @hannobraun @ryankurte