Skip to content

InputPin instead of OutputPin for compatibility shim#199

Closed
AdminXVII wants to merge 4 commits into
rust-embedded:v0.2.xfrom
AdminXVII:fix-pin
Closed

InputPin instead of OutputPin for compatibility shim#199
AdminXVII wants to merge 4 commits into
rust-embedded:v0.2.xfrom
AdminXVII:fix-pin

Conversation

@AdminXVII

@AdminXVII AdminXVII commented Apr 7, 2020

Copy link
Copy Markdown

The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.

@AdminXVII
InputPin instead of OutputPin for compatibility shim
7e87fab 
The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.
@AdminXVII AdminXVII requested review from a team, ilya-epifanov and thejpster as code owners April 7, 2020 00:11
@rust-highfive

rust-highfive commented Apr 7, 2020

Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive

rust-highfive commented Apr 7, 2020

Copy link
Copy Markdown

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.2.x. Please double check that you specified the right target!

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Apr 7, 2020
@AdminXVII AdminXVII mentioned this pull request Apr 7, 2020
Closed
ryankurte
ryankurte approved these changes Apr 7, 2020
View reviewed changes

@ryankurte ryankurte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

bors r+

bors Bot added a commit that referenced this pull request Apr 7, 2020
@bors @AdminXVII @ryankurte
Merge #199
e89399b 
199: InputPin instead of OutputPin for compatibility shim r=ryankurte a=AdminXVII

The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.

Co-authored-by: Xavier L'Heureux <dev.xlheureux@gmail.com>
Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
therealprof
therealprof approved these changes Apr 7, 2020
View reviewed changes

@therealprof therealprof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bors

bors Bot commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

Timed out

@ryankurte

ryankurte commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

bors retry

bors Bot added a commit that referenced this pull request Apr 8, 2020
@bors @AdminXVII @ryankurte
Merge #199
e42d803 
199: InputPin instead of OutputPin for compatibility shim r=ryankurte a=AdminXVII

The OldInputPin required OutputPin instead of InputPin for the new impl. Fix the trait bound.

Co-authored-by: Xavier L'Heureux <dev.xlheureux@gmail.com>
Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
@bors

bors Bot commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Build failed

@ryankurte

ryankurte commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

Failed due to dyn keyword requirement that is / was fixed in 961dfb8, i need to update v0.2.x to the latest non-breaking change (rather than a mirror of 0.2.3)

@ryankurte ryankurte mentioned this pull request Apr 19, 2020
Closed
eldruin added a commit to eldruin/embedded-hal that referenced this pull request Jun 10, 2020
@eldruin
Fix using InputPin instead of OutputPin
59f33ca 
Taken from rust-embedded#199
eldruin added a commit to eldruin/embedded-hal that referenced this pull request Jun 10, 2020
@eldruin
Update changelog with text from rust-embedded#199
55461c3
@eldruin eldruin mentioned this pull request Jun 10, 2020
Merged
bors Bot added a commit that referenced this pull request Jun 10, 2020
@bors @little-arhat
@ryankurte @eldruin
Merge #220
20fad3e 
220: [0.2.x] Fixes to digital compatibility shim r=ryankurte a=eldruin

I cherry-picked #138 and some improvements to docs and included #199.

Co-authored-by: Roma Sokolov <sokolov.r.v@gmail.com>
Co-authored-by: Ryan Kurte <ryankurte@gmail.com>
Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
@ryankurte

ryankurte commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

cherry-picked into #220, thanks @AdminXVII!

@ryankurte ryankurte closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankurte ryankurte ryankurte approved these changes

@therealprof therealprof therealprof approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

@thejpster thejpster Awaiting requested review from thejpster

Assignees

@thejpster thejpster

Labels

S-waiting-on-review Review is incomplete T-hal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AdminXVII @rust-highfive @ryankurte @therealprof @thejpster