Update reference implementation implementation to stm32f1xx-hal and update examples#251
Merged
bors[bot] merged 3 commits intoOct 6, 2020
Merged
Conversation
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
therealprof
approved these changes
Oct 6, 2020
therealprof
left a comment
therealprof
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks.
bors r+
Contributor
Member
Author
|
What do you think about removing the |
Contributor
|
Sounds good to me. |
Merged
bors Bot
added a commit
that referenced
this pull request
Oct 8, 2020
254: Remove futures examples r=therealprof a=eldruin The `futures`-based examples are stuck on `futures` `0.1`, require nightly to run the tests and do not represent how asynchronous processing will be done in embedded any more. In the `0.2.x` version these examples are still present. See [here](https://docs.rs/embedded-hal/0.2.4/embedded_hal/). See [async/await on embedded Rust](https://ferrous-systems.com/blog/async-on-embedded/). See #251 Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the
stm32f1xx-halis a good candidate for a reference implementation.I have also updated the examples accordingly and modernized them a bit.
An additional possibility would be to remove the
futuresexamples as well, since async handling will be different.Closes #156