Remove futures examples#254
Merged
Merged
Conversation
|
r? @therealprof (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
seems okay to drop futures examples for now, your thoughts @therealprof? |
Contributor
Yes, let's do that. We already entertained this idea in #251. |
eldruin
force-pushed
the
remove-futures-examples
branch
from
ca52642 to
8c22c63
Compare
eldruin
force-pushed
the
remove-futures-examples
branch
from
8c22c63 to
23557a5
Compare
therealprof
approved these changes
Oct 8, 2020
therealprof
left a comment
therealprof
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
bors r+
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
futures-based examples are stuck onfutures0.1, require nightly to run the tests and do not represent how asynchronous processing will be done in embedded any more.In the
0.2.xversion these examples are still present. See here.See async/await on embedded Rust.
See #251