Skip to content

Reduce default CHALK_SOLVER_MAX_SIZE to 100#11884

Closed
ivan wants to merge 1 commit into
rust-lang:masterfrom
ivan:chalk-100
Closed

Reduce default CHALK_SOLVER_MAX_SIZE to 100#11884
ivan wants to merge 1 commit into
rust-lang:masterfrom
ivan:chalk-100

Conversation

@ivan

@ivan ivan commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

This fixes #11370. Please see the investigation in #11370 (comment).

CHALK_SOLVER_MAX_SIZE needs to be high enough to deduce types (see #11072), but not so high as to cause "server panicked: overflow depth reached" (#11370)

@jhgg

jhgg commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

Keeping the max size the same but increasing the max depth did not solve your problem?

@ivan

ivan commented Apr 2, 2022

Copy link
Copy Markdown
Contributor Author

That's right. With the test repo in #11370 (comment) and

export CHALK_SOLVER_MAX_SIZE=150
export CHALK_OVERFLOW_DEPTH=30000

I still see these errors from rust-analyzer:

  • "Request textDocument/semanticTokens/full failed."
  • "Request textDocument/codeLens failed."
  • "The Rust Analyzer Language Server server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information."

@bors

bors commented May 1, 2022

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts.

This fixes #11370.

It needs to be high enough to deduce types (see #11072), but not so
high as to cause "server panicked: overflow depth reached" (#11370)
@bors

bors commented May 22, 2022

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #12281) made this pull request unmergeable. Please resolve the merge conflicts.

@lnicola

lnicola commented May 22, 2022

Copy link
Copy Markdown
Member

I've increased CHALK_OVERFLOW_DEPTH in #12281, that seems to fix the problem in most cases. The logic being that by the increased CHALK_SOLVER_MAX_SIZE needs an increased CHALK_OVERFLOW_DEPTH to be able to make progress.

@lnicola lnicola closed this May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'overflow depth reached' panic during syntax highlighting, when using aes + ctr + cipher

4 participants