Skip to content

Increase defalt chalk overflow depth to match max solver size#12281

Merged
bors merged 1 commit into
rust-lang:masterfrom
lnicola:increase-overflow-depth
May 22, 2022
Merged

Increase defalt chalk overflow depth to match max solver size#12281
bors merged 1 commit into
rust-lang:masterfrom
lnicola:increase-overflow-depth

Conversation

@lnicola

@lnicola lnicola commented May 17, 2022

Copy link
Copy Markdown
Member

@Perksey

Perksey commented May 20, 2022

Copy link
Copy Markdown

Setting this override in my environment worked flawlessly 🎉

@lnicola

lnicola commented May 20, 2022

Copy link
Copy Markdown
Member Author

Thanks for testing. Since you're here, can you see if a smaller value (500, 750 etc.) works in #12279?

@lnicola lnicola force-pushed the increase-overflow-depth branch from 083b4b4 to 8b56d42 Compare May 22, 2022 15:10
@lnicola lnicola marked this pull request as ready for review May 22, 2022 15:12
@lnicola

lnicola commented May 22, 2022

Copy link
Copy Markdown
Member Author

This is a somewhat risky, but not a large change, and it's pretty easy to work around. And it should hopefully fix our metrics action.

@bors r+

@bors

bors commented May 22, 2022

Copy link
Copy Markdown
Contributor

📌 Commit 8b56d42 has been approved by lnicola

@bors

bors commented May 22, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8b56d42 with merge 65a213c...

@bors

bors commented May 22, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 65a213c to master...

@bors bors merged commit 65a213c into rust-lang:master May 22, 2022
@lnicola lnicola deleted the increase-overflow-depth branch May 22, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants