Rollup of 6 pull requests by JonathanBrouwer · Pull Request #158043 · rust-lang/rust

JonathanBrouwer · 2026-06-17T17:25:41Z

Successful merges:

make more slice mutable ref getters rustc_no_writable #157816 (make more slice mutable ref getters rustc_no_writable)
Document that destructors in running threads are not run on program exit #156788 (Document that destructors in running threads are not run on program exit)
Add documentation for the must_use attribute #157957 (Add documentation for the must_use attribute)
Simplify HardwiredLints and SoftLints #158006 (Simplify HardwiredLints and SoftLints)
Pin dependencies #158007 (Pin dependencies)
Enable symbol_intern_string_literal lint for rustdoc #158025 (Enable symbol_intern_string_literal lint for rustdoc)

Document the built-in `must_use` attribute in the standard library using the `#[doc(attribute = "...")]` mechanism, following the existing `keyword_docs.rs` pattern.

To get a `LintVec` for a lint pass we sometimes use `get_lints` and sometimes use `lint_vec`. It would be nice to only have one, but doing that is tricky. In the meantime, this commit makes the naming more consistent. - By always using the name `get_lints` for the methods that take `self`. - By always using the name `lint_vec` for the methods that have no parameters.

These are both types that impl `LintPass` but in a degenerate way: only the `lint_vec` method is ever used. This commit changes them to just be a `lint_vec` function in an appropriately-named module. The commit also removes the use of `HardwiredLints` in `late_lint_crate`, which had no effect because all the `HardwiredLints::check_*` methods were no-ops.

- Document which pass each lint belongs to. - Make the lint ordering consistent. - Add (commented out) `SYMBOL_INTERN_STRING_LITERAL`, which was missing, with an explanation of why it's disabled.

And fix a few cases it catches.

Co-authored-by: Josh Triplett <josh@joshtriplett.org>

@quiode

…fonthey,saethlin make more slice mutable ref getters rustc_no_writable This makes https://rust.godbolt.org/z/TreEYqfW8 work. Cc @quiode @JoJoDeveloping

…ross Document that destructors in running threads are not run on program exit It's my understanding that, when a Rust program's main thread terminates and thereby causes any still-running threads to be shut down, destructors are not run for the shut-down threads; however, the documentation doesn't seem to come out and say that explicitly anywhere. This PR therefore adds an explicit statement about this to the `std::thread` docs. If I am mistaken and destructors *are* run, that's worth documenting explicitly, too.

@GuillaumeGomez

… r=GuillaumeGomez,ehuss Add documentation for the `must_use` attribute Document the built-in `must_use` attribute in the standard library using the `#[doc(attribute = "...")]` mechanism, following the existing `keyword_docs.rs` pattern. Part of rust-lang#157604. r? @GuillaumeGomez Tested with `./x test library/std --doc`.

@Urgau

…s-SoftLints, r=Urgau Simplify `HardwiredLints` and `SoftLints` Details in individual commits. r? @Urgau

…cies, r=marcoieni Pin dependencies This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://redirect.github.com/actions/checkout) | action | pinDigest | → `93cb6ef` | | [actions/download-artifact](https://redirect.github.com/actions/download-artifact) | action | pinDigest | → `3e5f45b` | | [actions/upload-artifact](https://redirect.github.com/actions/upload-artifact) | action | pinDigest | → `043fb46` | --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rust-lang/rust).

@Urgau

…iteral-rustdoc, r=Urgau Enable `symbol_intern_string_literal` lint for rustdoc Details in individual commits. r? @Urgau

JonathanBrouwer · 2026-06-17T17:25:53Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

rust-bors · 2026-06-17T17:25:57Z

📌 Commit ed85b5b has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

rust-bors · 2026-06-17T20:46:40Z

☀️ Try build successful (CI)
Build commit: 9e5ee08 (9e5ee0882593b8aed3169fa19a3ee35c0ae7ce82)
Base parent: 693b3e4 (693b3e4c6e4e686cb9878c1722ad26858b5f1d2a)

rust-bors · 2026-06-17T21:21:14Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 20m 55s
Pushing c1b22f4 to main...

rust-timer · 2026-06-17T21:23:04Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#156788	Document that destructors in running threads are not run on…	`b4c19e5726d4a9f29b357e1bcf46c30fe5230604` (link)
#157816	make more slice mutable ref getters rustc_no_writable	`40c3e787a578411486d58f636464504594f93675` (link)
#157957	Add documentation for the `must_use` attribute	`b3711c3ed01f77e938a8736dd8300060148f0a98` (link)
#158006	Simplify `HardwiredLints` and `SoftLints`	`cd17c1f8cf5660f16ecc1a4443df24c9e00b6b3e` (link)
#158007	Pin dependencies	`13e7e480107ad4e83fbff247d2745aaf9be0e4e1` (link)
#158025	Enable `symbol_intern_string_literal` lint for rustdoc	`68da737fc5580b99d18922df6af4fedbaf895efd` (link)

previous master: 693b3e4c6e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-06-17T21:25:21Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 693b3e4 (parent) -> c1b22f4 (this PR)

Test differences

Show 718 test diffs

718 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c1b22f44c3f30e186b829de95f59740c3a690aba --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc-core-tests: 8m 16s -> 15m 8s (+82.9%)
test-various: 1h 14m -> 2h 7m (+70.7%)
x86_64-gnu-llvm-22-3: 1h 29m -> 2h 16m (+52.6%)
pr-check-2: 31m 45s -> 47m 25s (+49.3%)
armhf-gnu: 1h 9m -> 1h 32m (+33.1%)
dist-x86_64-llvm-mingw: 1h 36m -> 2h 7m (+32.1%)
x86_64-gnu-llvm-22-1: 57m 47s -> 1h 16m (+31.8%)
dist-x86_64-musl: 1h 47m -> 2h 19m (+30.2%)
pr-check-1: 27m 21s -> 35m 14s (+28.8%)
x86_64-gnu-debug: 1h 56m -> 2h 21m (+20.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-06-17T22:33:51Z

Finished benchmarking commit (c1b22f4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Cycles

Results (secondary -7.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.0%	[-7.0%, -7.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 522.375s -> 523.599s (0.23%)
Artifact size: 401.89 MiB -> 401.32 MiB (-0.14%)

softfault and others added 15 commits June 17, 2026 00:15

Add documentation for the must_use attribute

72b3123

Document the built-in `must_use` attribute in the standard library using the `#[doc(attribute = "...")]` mechanism, following the existing `keyword_docs.rs` pattern.

Clean up register_internals

d18a8ef

- Document which pass each lint belongs to. - Make the lint ordering consistent. - Add (commented out) `SYMBOL_INTERN_STRING_LITERAL`, which was missing, with an explanation of why it's disabled.

Enable symbol_intern_string_literal for rustdoc.

af9a706

And fix a few cases it catches.

Pin dependencies

5258468

Document that destructors in running threads are not run on program exit

8410d26

Co-authored-by: Josh Triplett <josh@joshtriplett.org>

move test

b014e28

make more slice mutable ref getters rustc_no_writable

70a99d8

Rollup merge of rust-lang#157816 - RalfJung:rustc_no_writable, r=clar…

7d9e765

…fonthey,saethlin make more slice mutable ref getters rustc_no_writable This makes https://rust.godbolt.org/z/TreEYqfW8 work. Cc @quiode @JoJoDeveloping

Rollup merge of rust-lang#158006 - nnethercote:simplify-HardwiredLint…

1113eb0

…s-SoftLints, r=Urgau Simplify `HardwiredLints` and `SoftLints` Details in individual commits. r? @Urgau

Rollup merge of rust-lang#158025 - nnethercote:symbol_intern_string_l…

ed85b5b

…iteral-rustdoc, r=Urgau Enable `symbol_intern_string_literal` lint for rustdoc Details in individual commits. r? @Urgau

rust-bors Bot added the rollup A PR which is a rollup label Jun 17, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 17, 2026

rust-bors Bot merged commit c1b22f4 into rust-lang:main Jun 17, 2026
15 checks passed

rustbot added this to the 1.98.0 milestone Jun 17, 2026

midnightveil mentioned this pull request Jun 18, 2026

report benchmarking regressions seL4/ci-actions#76

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests#158043

Rollup of 6 pull requests#158043
rust-bors[bot] merged 15 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-dYC8IEa

JonathanBrouwer commented Jun 17, 2026

Uh oh!

JonathanBrouwer commented Jun 17, 2026

Uh oh!

rust-bors Bot commented Jun 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 17, 2026

Uh oh!

rust-bors Bot commented Jun 17, 2026

Uh oh!

Uh oh!

rust-timer commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

rust-timer commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

JonathanBrouwer commented Jun 17, 2026

Uh oh!

JonathanBrouwer commented Jun 17, 2026

Uh oh!

rust-bors Bot commented Jun 17, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 17, 2026

Uh oh!

rust-bors Bot commented Jun 17, 2026

Uh oh!

Uh oh!

rust-timer commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 17, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants