Skip to content

Rollup of 3 pull requests#158184

Merged
rust-bors[bot] merged 63 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ABE3nZj
Jun 20, 2026
Merged

Rollup of 3 pull requests#158184
rust-bors[bot] merged 63 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ABE3nZj

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

Herrtian and others added 30 commits May 31, 2026 18:03
…piler-flags-972

Document adding unstable compiler flags
…reddevilmidzy-patch-1

Fix formatting in attribute-parsing documentation
…rm64-mac

Update autodiff installation guide
…s-new

Use new name for `custom_messages` in triagebot config
Start basic docs for pre-stabilization CI job
Signed-off-by: cuishuang <imcusg@gmail.com>
Some may not see 30s as "very fast", so keep the sentence objective
- TL;DR is something many would not know the meaning of.
- Remove sentence that is implied
make more clear the content is in current book
Update stale GenericArgs example
tshepang and others added 9 commits June 20, 2026 16:15
…=Urgau

Only copy visible content in clipboard in source code pages

You can see this bug but enabling the `--generate-macro-expansion` rustdoc option. When selecting text which contains a macro expansion, it'll copy all the code, both displayed and hidden. To reproduce it, take a look [here](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_middle/hir/mod.rs.html#26-27).

This PR fixes it.

I'm currently adding the missing bits in `browser-ui-test` to be able to add a GUI regression test for it (selecting text and doing "ctrl-c").

The code I removed was added to fix both rust-lang#146816 and rust-lang#142354. However, I couldn't reproduce the bug in firefox 152 and in chromium 149. So instead of trying to handle more corner-cases, it's better to just remove the whole code. :)

r? @Urgau
rustc-dev-guide subtree update

Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@15388a6.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jun 20, 2026
@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 20, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 53c6a7f has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2026
@rust-bors

rust-bors Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 10m 37s
Pushing 8b6558a to main...

@rust-bors rust-bors Bot merged commit 8b6558a into rust-lang:main Jun 20, 2026
14 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 20, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#158137 Only copy visible content in clipboard in source code pages 719e69040fd4e10e66e9ddc8ef7a5798fbb25da3 (link)
#158141 [AArch64] FEAT_SVE implies FEAT_FP16 eee5ca021c4efefe26bba73582db66ccce23cf7f (link)
#158177 rustc-dev-guide subtree update 666bf08d9b73146b4a3df862f11eb087bb4cb66c (link)

previous master: fffed276b5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing fffed27 (parent) -> 8b6558a (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8b6558a02b2774acfb25cf15e199467c37ba7490 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. i686-msvc-2: 1h 33m -> 2h 9m (+39.0%)
  2. i686-gnu-nopt-1: 1h 36m -> 2h 13m (+37.8%)
  3. x86_64-msvc-1: 1h 57m -> 2h 41m (+37.3%)
  4. x86_64-mingw-1: 2h 14m -> 2h 54m (+30.0%)
  5. x86_64-gnu-llvm-22-2: 1h 16m -> 1h 36m (+26.0%)
  6. x86_64-gnu-llvm-22-1: 1h 9m -> 52m 17s (-24.4%)
  7. x86_64-msvc-2: 1h 52m -> 2h 19m (+23.6%)
  8. x86_64-gnu-llvm-21: 1h 11m -> 54m 33s (-23.4%)
  9. tidy: 2m 32s -> 1m 59s (-22.0%)
  10. x86_64-mingw-2: 2h 36m -> 2h 2m (-21.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8b6558a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.7%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
-2.7% [-3.7%, -1.6%] 2
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) -2.7% [-3.7%, -1.6%] 2

Cycles

Results (primary 2.0%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
2.9% [2.3%, 3.8%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.0% [2.0%, 2.0%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 481.959s -> 482.01s (0.01%)
Artifact size: 390.78 MiB -> 391.28 MiB (0.13%)

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  COMMIT_MESSAGE: cargo update 
##[endgroup]
Downloading single artifact
Preparing to download the following artifacts:
- Cargo-lock (ID: 7770419920, Size: 49913, Expected Digest: sha256:01b9c3e1a884069ab3ea5321a3e70ef1ba39a72576316472b306a085658e1aa8)
Redirecting to blob download url: https://productionresultssa6.blob.core.windows.net/actions-results/1c3c9442-db01-45a3-acbc-48308ed6067f/workflow-job-run-65bea33a-bd62-5beb-b879-813dd96c9173/artifacts/858175980ba8726bab9f963fd06060d5199d874bbd735e523e2d990d354f8c0b.zip
Starting download of artifact to: /home/runner/work/rust/rust
(node:2292) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
SHA256 digest of downloaded artifact is 01b9c3e1a884069ab3ea5321a3e70ef1ba39a72576316472b306a085658e1aa8
Artifact download completed successfully.
Total of 1 artifact(s) downloaded
Download artifact has finished successfully
---
  COMMIT_MESSAGE: cargo update 
##[endgroup]
Downloading single artifact
Preparing to download the following artifacts:
- cargo-updates (ID: 7770420029, Size: 2516, Expected Digest: sha256:f0ad5679a5b93984839bc63e86c00a8c519bcf613809d0f44bd38f38c06f828e)
Redirecting to blob download url: https://productionresultssa6.blob.core.windows.net/actions-results/1c3c9442-db01-45a3-acbc-48308ed6067f/workflow-job-run-65bea33a-bd62-5beb-b879-813dd96c9173/artifacts/ce9034d4568b3430f906da1368ae1cf3e14ef1542859eb2e8d635c0876371f53.zip
Starting download of artifact to: /home/runner/work/rust/rust
(node:2305) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
SHA256 digest of downloaded artifact is f0ad5679a5b93984839bc63e86c00a8c519bcf613809d0f44bd38f38c06f828e
Artifact download completed successfully.
Total of 1 artifact(s) downloaded
Download artifact has finished successfully
##[group]Run echo "${COMMIT_MESSAGE}" > commit.txt
echo "${COMMIT_MESSAGE}" > commit.txt
cat cargo_update.log >> commit.txt

echo "${PR_MESSAGE}" > body.md
echo '```txt' >> body.md
cat cargo_update.log >> body.md
echo '```' >> body.md
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
dep-bumps
following is the output from `cargo update`:
  COMMIT_MESSAGE: cargo update 
##[endgroup]
##[group]Run git config user.name github-actions
git config user.name github-actions
git config user.email github-actions@github.com
git switch --force-create cargo_update
git add ./Cargo.lock ./library/Cargo.lock ./src/tools/rustbook/Cargo.lock
git commit --no-verify --file=commit.txt
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
dep-bumps
following is the output from `cargo update`:
  COMMIT_MESSAGE: cargo update 
##[endgroup]
remote: error: GH013: Repository rule violations found for refs/heads/cargo_update.        
remote: Review all repository rules at https://github.com/rust-lang/rust/rules?ref=refs%2Fheads%2Fcargo_update        
remote: 
remote: - Cannot update this protected ref.        
remote: 
remote: - Changes must be made through a pull request.        
remote: 
remote: - Cannot force-push to this branch        
remote: 
To https://github.com/rust-lang/rust
 ! [remote rejected]   cargo_update -> cargo_update (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/rust-lang/rust'
##[error]Process completed with exit code 1.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustc-dev-guide Area: rustc-dev-guide A-rustdoc-js Area: Rustdoc's JS front-end merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.