Batch up libsyntax breaking changes by Manishearth · Pull Request #33864 · rust-lang/rust

Manishearth · 2016-05-25T08:17:52Z

This makes the "shadowing labels" warning *not* print the entire loop as a span, but only the lifetime. Also makes rust-lang#31719 go away, but does not fix its root cause (the span of the expanded loop is still wonky, but not used anymore).

This is more idiomatic, putting the caller in charge of whether or not to panic.

rust-highfive · 2016-05-25T08:17:58Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

Manishearth · 2016-05-25T08:18:03Z

@bors r+ p=20

bors · 2016-05-25T08:18:03Z

📌 Commit 5bc8cdd has been approved by Manishearth

bors · 2016-05-25T09:20:32Z

⌛ Testing commit 5bc8cdd with merge d2bc653...

bors · 2016-05-25T09:33:28Z

💔 Test failed - auto-linux-64-nopt-t

Manishearth · 2016-05-25T09:37:36Z

@petrochenkov

../src/librustc_resolve/lib.rs:610:31: 610:48 error: attempted access of field `explicit_self` on type `&syntax::ast::MethodSig`, but no field with that name was found
../src/librustc_resolve/lib.rs:610                 MethodRibKind(sig.explicit_self.node == SelfKind::Static)
                                                                 ^~~~~~~~~~~~~~~~~
../src/librustc_resolve/lib.rs:610:57: 610:73 error: no associated item named `Static` found for type `syntax::ast::SelfKind` in the current scope
../src/librustc_resolve/lib.rs:610                 MethodRibKind(sig.explicit_self.node == SelfKind::Static)
                                                                                           ^~~~~~~~~~~~~~~~
../src/librustc_resolve/lib.rs:1680:62: 1680:79 error: attempted access of field `explicit_self` on type `&syntax::ast::MethodSig`, but no field with that name was found
../src/librustc_resolve/lib.rs:1680                                                              sig.explicit_self.node ==
                                                                                                 ^~~~~~~~~~~~~~~~~
../src/librustc_resolve/lib.rs:1681:62: 1681:78 error: no associated item named `Static` found for type `syntax::ast::SelfKind` in the current scope
../src/librustc_resolve/lib.rs:1681                                                              SelfKind::Static));
                                                                                                 ^~~~~~~~~~~~~~~~
../src/librustc_resolve/lib.rs:2011:61: 2011:78 error: attempted access of field `explicit_self` on type `&syntax::ast::MethodSig`, but no field with that name was found
../src/librustc_resolve/lib.rs:2011                                                             sig.explicit_self.node ==
                                                                                                ^~~~~~~~~~~~~~~~~
../src/librustc_resolve/lib.rs:2012:61: 2012:77 error: no associated item named `Static` found for type `syntax::ast::SelfKind` in the current scope
../src/librustc_resolve/lib.rs:2012                                                             SelfKind::Static));
                                                                                                ^~~~~~~~~~~~~~~~
error: aborting due to 6 previous errors
make: *** [x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib/stamp.rustc_resolve] Error 101

looks like a recent change broke your PR?

petrochenkov · 2016-05-25T09:52:38Z

Looks like it, I'll rebase it this evening.

petrochenkov · 2016-05-25T19:21:23Z

@Manishearth
I've rebased both my PRs.

Manishearth · 2016-05-26T04:38:26Z

command line snippet

mergerollup birkenfeld:loop-label-spans 33351 pnkfelix
mergerollup petrochenkov:dotdot 33639 nmatsakis
mergerollup petrochenkov:selfast 33644 nrc
mergerollup kamalmarhubi:codemape-get-filemap-option 33839  nmatsakis

Manishearth · 2016-05-26T05:00:03Z

@bors r+ p=10

bors · 2016-05-26T05:00:03Z

📌 Commit 2b73335 has been approved by Manishearth

bors · 2016-05-26T06:49:12Z

⌛ Testing commit 2b73335 with merge c4dd066...

Batch up libsyntax breaking changes cc #31645

bors · 2016-05-26T07:52:58Z

💔 Test failed - auto-mac-64-opt

Manishearth · 2016-05-26T08:02:51Z

@petrochenkov pat-tuple-overfield fails

petrochenkov · 2016-05-26T08:13:28Z

pat-tuple-overfield fails

I'm sure it passed locally yesterday, something probably changed again, I'm investigating.

petrochenkov · 2016-05-26T08:36:19Z

This is very strange, the test still passes locally after rebase even if it shouldn't be platform-dependent. I've pushed one more commit, splitting this test into two. Also, maybe let's try a clean rebuild?

Manishearth · 2016-05-26T09:31:40Z

@bors try clean

bors · 2016-05-26T11:13:00Z

💔 Test failed - auto-linux-64-opt

Manishearth · 2016-05-26T11:14:27Z

@bors retry

exception

bors · 2016-05-26T14:25:38Z

⌛ Testing commit 74651d0 with merge e1a647f...

bors · 2016-05-26T15:32:20Z

💔 Test failed - auto-mac-64-opt

Manishearth · 2016-05-26T15:39:30Z


failures:

---- [compile-fail] compile-fail/pat-tuple-overfield-1.rs stdout ----

error: compiler encountered internal error
status: exit code: 101
command: x86_64-apple-darwin/stage2/bin/rustc /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/test/compile-fail/pat-tuple-overfield-1.rs -L x86_64-apple-darwin/test/compile-fail/ --target=x86_64-apple-darwin --error-format json -Z unstable-options -L x86_64-apple-darwin/test/compile-fail/pat-tuple-overfield-1.stage2-x86_64-apple-darwin.compile-fail.libaux -C prefer-dynamic -o x86_64-apple-darwin/test/compile-fail/pat-tuple-overfield-1.stage2-x86_64-apple-darwin --cfg rtopt -C rpath -O -L x86_64-apple-darwin/rt
stdout:
------------------------------------------
thread 'rustc' panicked at 'arithmetic operation overflowed', ../src/librustc/hir/pat_util.rs:53
note: Run with `RUST_BACKTRACE=1` for a backtrace.


------------------------------------------
stderr:
------------------------------------------
{"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n\nAnother situation in which this occurs is when you attempt to use the `try!`\nmacro inside a function that does not return a `Result<T, E>`:\n\n```compile_fail\nuse std::fs::File;\n\nfn main() {\n    let mut f = try!(File::create(\"foo.txt\"));\n}\n```\n\nThis code gives an error like this:\n\n```text\n<std macros>:5:8: 6:42 error: mismatched types:\n expected `()`,\n     found `core::result::Result<_, _>`\n (expected (),\n     found enum `core::result::Result`) [E0308]\n```\n\n`try!` returns a `Result<T, E>`, and so the function must. But `main()` has\n`()` as its return type, hence the error.\n"},"level":"error","spans":[{"file_name":"/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/test/compile-fail/pat-tuple-overfield-1.rs","byte_start":548,"byte_end":560,"line_start":15,"line_end":15,"column_start":9,"column_end":21,"is_primary":true,"text":[{"text":"        (1, 2, 3, 4) => {} //~ ERROR mismatched types","highlight_start":9,"highlight_end":21}],"label":"expected a tuple with 3 elements, found one with 4 elements","suggested_replacement":null,"expansion":null}],"children":[{"message":"expected type `(_, _, _)`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"   found type `(_, _, _, _)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":null}
{"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n\nAnother situation in which this occurs is when you attempt to use the `try!`\nmacro inside a function that does not return a `Result<T, E>`:\n\n```compile_fail\nuse std::fs::File;\n\nfn main() {\n    let mut f = try!(File::create(\"foo.txt\"));\n}\n```\n\nThis code gives an error like this:\n\n```text\n<std macros>:5:8: 6:42 error: mismatched types:\n expected `()`,\n     found `core::result::Result<_, _>`\n (expected (),\n     found enum `core::result::Result`) [E0308]\n```\n\n`try!` returns a `Result<T, E>`, and so the function must. But `main()` has\n`()` as its return type, hence the error.\n"},"level":"error","spans":[{"file_name":"/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/test/compile-fail/pat-tuple-overfield-1.rs","byte_start":602,"byte_end":618,"line_start":16,"line_end":16,"column_start":9,"column_end":25,"is_primary":true,"text":[{"text":"        (1, 2, .., 3, 4) => {} //~ ERROR mismatched types","highlight_start":9,"highlight_end":25}],"label":"expected a tuple with 3 elements, found one with 4 elements","suggested_replacement":null,"expansion":null}],"children":[{"message":"expected type `(_, _, _)`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"   found type `(_, _, _, _)`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":null}
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

------------------------------------------

thread '[compile-fail] compile-fail/pat-tuple-overfield-1.rs' panicked at 'explicit panic', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/tools/compiletest/src/runtest.rs:2238

ICE? o.o

petrochenkov · 2016-05-26T15:47:47Z

Ugh. I see why it passed locally, because overflow checks are disabled by default.
I know what is the reason, I'll fix it this evening.
(Where's our list of bugs caught by overflow checking?)

Manishearth · 2016-05-26T15:50:46Z

@pnkfelix One more for your list!

petrochenkov · 2016-05-26T20:43:45Z

Updated.

…elix This makes the \"shadowing labels\" warning *not* print the entire loop as a span, but only the lifetime. Also makes rust-lang#31719 go away, but does not fix its root cause (the span of the expanded loop is still wonky, but not used anymore).

@nikomatsakis

cc rust-lang#33627 r? @nikomatsakis plugin-[breaking-change] cc rust-lang#31645 @Manishearth

@nrc

The AST part of rust-lang#33505. rust-lang#33505 isn't landed yet, so this PR is based on top of it. r? @nrc plugin-[breaking-change] cc rust-lang#31645 @Manishearth

…ption, r=nmatsakis This is more idiomatic, putting the caller in charge of whether or not to panic.

Manishearth · 2016-05-27T05:44:51Z

@bors r+

bors · 2016-05-27T05:44:51Z

📌 Commit 63dfbdb has been approved by Manishearth

Manishearth · 2016-05-27T05:46:05Z

@bors force

bors · 2016-05-27T05:46:09Z

⌛ Testing commit 63dfbdb with merge 36d5dc7...

Batch up libsyntax breaking changes cc #31645

bors · 2016-05-27T10:56:17Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

Manishearth · 2016-07-12T00:22:10Z

List for next breaking batch (unplanned as of now):

Attributes on generic formals #34764 (r=eddyb)

pnkfelix · 2016-07-12T11:12:52Z

(Where's our list of bugs caught by overflow checking?)

Here! https://github.com/pnkfelix/collab-docs/blob/master/rust/arith-overflow-buglist.md

Manishearth · 2016-08-01T13:24:42Z

Next breaking batch will happen soon, including just #34764 unless any more PRs appear.

cc @petrochenkov if you have anything you need merged

birkenfeld and others added 2 commits May 24, 2016 14:22

syntax/hir: give loop labels a span

2e812e1

This makes the "shadowing labels" warning *not* print the entire loop as a span, but only the lifetime. Also makes rust-lang#31719 go away, but does not fix its root cause (the span of the expanded loop is still wonky, but not used anymore).

syntax: Make codemap::get_filemap() return an Option

3bef085

This is more idiomatic, putting the caller in charge of whether or not to panic.

rust-highfive assigned arielb1 May 25, 2016

Manishearth mentioned this pull request May 25, 2016

Tracking issue for libsyntax breaking changes #31645

Closed

petrochenkov added 3 commits May 25, 2016 21:55

Remove ExplicitSelf from AST

5660a00

Add a new AST-only type variant ImplicitSelf

1a1de5b

Fix rebase

dcea4b2

Manishearth force-pushed the breaking-batch branch from 5bc8cdd to 2b73335 Compare May 26, 2016 04:59

bors added a commit that referenced this pull request May 26, 2016

Auto merge of #33864 - Manishearth:breaking-batch, r=Manishearth

c4dd066

Batch up libsyntax breaking changes cc #31645

petrochenkov added 3 commits May 26, 2016 11:11

Implement .. in tuple (struct) patterns

d69aeaf

Address review comments

c038b45

Replace pat_adjust_pos with an iterator adapter

35ef09c

Fix overflow in type checking of tuple patterns

0ca9bf3

Manishearth added 4 commits May 27, 2016 09:56

Rollup merge of rust-lang#33639 - petrochenkov:dotdot, r=nmatsakis

3578571

cc rust-lang#33627 r? @nikomatsakis plugin-[breaking-change] cc rust-lang#31645 @Manishearth

Rollup merge of rust-lang#33644 - petrochenkov:selfast, r=nrc

7905452

The AST part of rust-lang#33505. rust-lang#33505 isn't landed yet, so this PR is based on top of it. r? @nrc plugin-[breaking-change] cc rust-lang#31645 @Manishearth

Rollup merge of rust-lang#33839 - kamalmarhubi:codemape-get-filemap-o…

63dfbdb

…ption, r=nmatsakis This is more idiomatic, putting the caller in charge of whether or not to panic.

Manishearth force-pushed the breaking-batch branch from 74651d0 to 63dfbdb Compare May 27, 2016 05:43

bors added a commit that referenced this pull request May 27, 2016

Auto merge of #33864 - Manishearth:breaking-batch, r=Manishearth

36d5dc7

Batch up libsyntax breaking changes cc #31645

bors merged commit 63dfbdb into rust-lang:master May 27, 2016

bors mentioned this pull request May 27, 2016

Add AST validation pass and move some checks to it #33794

Merged

Manishearth deleted the breaking-batch branch May 27, 2016 10:57

mcarton mentioned this pull request May 27, 2016

Rustup to *1.10.0-nightly (7bddce693 2016-05-27)* rust-lang/rust-clippy#958

Merged

pnkfelix mentioned this pull request Jul 12, 2016

Overflow in hir/pat_util code pnkfelix/collab-docs#4

Closed

Uh oh!

Conversation

Manishearth commented May 25, 2016

Uh oh!

rust-highfive commented May 25, 2016

Uh oh!

Manishearth commented May 25, 2016

Uh oh!

bors commented May 25, 2016

Uh oh!

bors commented May 25, 2016

Uh oh!

bors commented May 25, 2016

Uh oh!

Manishearth commented May 25, 2016

Uh oh!

petrochenkov commented May 25, 2016

Uh oh!

petrochenkov commented May 25, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

petrochenkov commented May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented May 26, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

bors commented May 26, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

petrochenkov commented May 26, 2016

Uh oh!

Manishearth commented May 26, 2016

Uh oh!

petrochenkov commented May 26, 2016

Uh oh!

Manishearth commented May 27, 2016

Uh oh!

bors commented May 27, 2016

Uh oh!

Manishearth commented May 27, 2016

Uh oh!

bors commented May 27, 2016

Uh oh!

bors commented May 27, 2016

Uh oh!

Manishearth commented Jul 12, 2016

Uh oh!

pnkfelix commented Jul 12, 2016

Uh oh!

Manishearth commented Aug 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

petrochenkov commented May 26, 2016 •

edited

Loading

Manishearth commented Aug 1, 2016 •

edited

Loading