minor fix about visibility in reference#38215
Merged
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
You mentioned that trait items are public by default. Can I make a trait item private? |
Contributor
Author
|
you can't, at least currently, we don't use |
petrochenkov
reviewed
Dec 7, 2016
Contributor
There was a problem hiding this comment.
Associated items and variants are not public by default, they inherit visibility from their traits and enums respectively. E.g.
pub(vis) trait Tr {
fn f();
}
is "desugared" into
pub(vis) trait Tr {
pub(vis) fn f(); // (Not syntactically legal now)
}
Contributor
|
Looks like @petrochenkov 's feedback needs to be addressed. |
Contributor
Author
|
done. |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit e095c71 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 15, 2016
minor fix about visibility in reference
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 16, 2016
minor fix about visibility in reference
Collaborator
|
⌛ Testing commit e095c71 with merge 69aa86a... |
Collaborator
|
💔 Test failed - auto-mac-64-opt-rustbuild |
Member
|
@bors: retry |
Collaborator
|
⌛ Testing commit e095c71 with merge dea9316... |
Collaborator
|
💔 Test failed - auto-mac-64-opt-rustbuild |
Member
|
@bors: retry
…On Fri, Dec 16, 2016 at 7:57 AM, bors ***@***.***> wrote:
💔 Test failed - auto-mac-64-opt-rustbuild
<https://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/3276>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38215 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95LDM-RmA4rFp3im_A-ycSxBaYA7kks5rIrTmgaJpZM4LGU5m>
.
|
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 18, 2016
minor fix about visibility in reference
Contributor
|
@bors retry |
Member
|
@bors: retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 20, 2016
minor fix about visibility in reference
bors
added a commit
that referenced
this pull request
Dec 20, 2016
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.