Unix socket doc#38236
Conversation
There was a problem hiding this comment.
This example doesn't seem particularly helpful :)
There was a problem hiding this comment.
IMHO every single example exhaustively matching on socket creation is sort of overzealous.
if let Ok(socket) = UnixListener::bind("/tmp/sock") {
// show off the feature
}
would be a much better alternative IMO.
EDIT: exhaustive matching is fine on the examples of functions that do the actual socket creation, though.
There was a problem hiding this comment.
I think I'll just go for unwrap for the other cases.
There was a problem hiding this comment.
I don't see it as an issue here, on the opposite. The point is to show people how it works, and creating a (unused) variable helps it.
There was a problem hiding this comment.
Couldn’t create a pair of sockets.
GuillaumeGomez
force-pushed
the
unix_socket_doc
branch
from
6c5046c to
878341f
Compare
|
Updated. |
GuillaumeGomez
force-pushed
the
unix_socket_doc
branch
2 times, most recently
from
477ba42 to
fdbd760
Compare
|
And urls fixed as well. Build fails but doesn't have errors so I guess it's okay? |
frewsxcv
left a comment
frewsxcv
left a comment
There was a problem hiding this comment.
Looks good, just a few comments 🎊
There was a problem hiding this comment.
Nit: 'nonblocking' is one word
There was a problem hiding this comment.
Nit: why is "AU" capitalized?
There was a problem hiding this comment.
To help english people improve their french. :p
There was a problem hiding this comment.
For me, a person who doesn't know any French, it doesn't help me learn French, it just makes me confused :)
There was a problem hiding this comment.
Haha. Well, I'll "fixed" it then.
There was a problem hiding this comment.
Can we add an example here where is_unnamed() is true?
There was a problem hiding this comment.
Same here. If we can create an unnamed socket, can we show here that as_pathname() is None?
GuillaumeGomez
force-pushed
the
unix_socket_doc
branch
from
fdbd760 to
6011527
Compare
|
Updated. |
frewsxcv
left a comment
frewsxcv
left a comment
There was a problem hiding this comment.
r=me unless you want to address the nits
There was a problem hiding this comment.
Nit: Alternatively, you could also do something like this:
# Examples
An unnamed address:
```
...
```
A named address:
```
...
```
There was a problem hiding this comment.
Nit: The ellipsis here doesn't seem necessary.
There was a problem hiding this comment.
The ellipsis? What do you mean? The expect call?
There was a problem hiding this comment.
GuillaumeGomez
force-pushed
the
unix_socket_doc
branch
from
6011527 to
2979946
Compare
|
I addressed the nits. |
There was a problem hiding this comment.
Did you want to do the same thing here?
|
r=me unless you want to address that comment |
GuillaumeGomez
force-pushed
the
unix_socket_doc
branch
from
2979946 to
cc180fb
Compare
|
And updated too. |
|
@bors r+ rollup 🎉 |
|
📌 Commit cc180fb has been approved by |
…rewsxcv Unix socket doc r? @frewsxcv
|
@bors r- Errors: #38387 (comment) |
GuillaumeGomez
force-pushed
the
unix_socket_doc
branch
from
cc180fb to
2938e6a
Compare
|
📌 Commit 2938e6a has been approved by |
…rewsxcv Unix socket doc r? @frewsxcv
|
⌛ Testing commit 2938e6a with merge 1ca362c... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@bors: retry |
|
⌛ Testing commit 2938e6a with merge 92039a2... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@bors: retry
…On Fri, Dec 16, 2016 at 7:59 AM, bors ***@***.***> wrote:
💔 Test failed - auto-mac-64-opt-rustbuild
<https://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/3277>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38236 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AkNg-hoR9IvK-BHpnHYUbjLkOxUks5rIrV4gaJpZM4LHd2K>
.
|
…rewsxcv Unix socket doc r? @frewsxcv
|
@bors retry |
|
@bors: retry |
…rewsxcv Unix socket doc r? @frewsxcv
Rollup of 29 pull requests - Successful merges: #37761, #38006, #38131, #38150, #38158, #38171, #38208, #38215, #38236, #38245, #38289, #38302, #38315, #38346, #38388, #38395, #38398, #38418, #38432, #38451, #38463, #38468, #38470, #38471, #38472, #38478, #38486, #38493, #38498 - Failed merges: #38271, #38483
6 participants
r? @frewsxcv