Merged
Conversation
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
carols10cents
added
the
S-waiting-on-review
Member
|
Thanks for the PR! We’ll periodically check in on it to make sure that @aturon or someone else from the team reviews it soon. |
Member
Contributor
|
@bors r+ rollup thanks! |
Collaborator
|
📌 Commit 7d1c14a has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 10, 2017
Fix typo in codegen test Without the `:`, the `CHECK-NOT` is ignored by FileCheck, making the line not test anything.
bors
added a commit
that referenced
this pull request
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the
:, theCHECK-NOTis ignored by FileCheck, making the line not test anything.