Merged
Conversation
`PhantomData<*const T>` has the implication of Send / Syncness following the *const T type, but the discriminant should always be Send and Sync. Use `PhantomData<fn() -> T>` which has the same variance in T, but is Send + Sync
- function has been renamed to check_method_receiver
The value was generated according to [this comment by @japaric](rust-lang#31367 (comment)).
Improve diagnostics for `x as usize << y`
It seems like the file wasn't actually used, since there is a built-in target with the same name. See rust-lang#45108 (comment) for more details.
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors r+ p=10 |
Collaborator
|
📌 Commit a128bee has been approved by |
Collaborator
|
⌛ Testing commit a128bee35751f566999ebbcdfa47248b46adc870 with merge 22d6f45ee0161cae1175640ee52d50a3347fb6d0... |
Collaborator
|
💔 Test failed - status-appveyor |
Refactor to use `debug_struct` in several Debug impls Also use `pad` and derive `Debug` for `Edge`. Fixes rust-lang#44771.
Fix typo in codegen test Without the `:`, the `CHECK-NOT` is ignored by FileCheck, making the line not test anything.
…xcrichton Ensure std::mem::Discriminant is Send + Sync `PhantomData<*const T>` has the implication of Send / Syncness following the *const T type, but the discriminant should always be Send and Sync. Use `PhantomData<fn() -> T>` which has the same variance in T, but is Send + Sync
…ents, r=nikomatsakis Update comments referring to old check_method_self_type I was browsing the code base, trying to figure out how rust-lang#44874 could be implemented, and noticed some comments that were out of date and a bit misleading (`check_method_self_type` has since been renamed to `check_method_receiver`). Thought it would be an easy first contribution to Rust!
…jseyfried Make the result of `Literal::string()` more readable Closes rust-lang#45076
Fix data-layout field in x86_64-unknown-linux-gnu.json test file The current data-layout causes the following error: > rustc: /checkout/src/llvm/lib/CodeGen/MachineFunction.cpp:151: void llvm::MachineFunction::init(): Assertion `Target.isCompatibleDataLayout(getDataLayout()) && "Can't create a MachineFunction using a Module with a " "Target-incompatible DataLayout attached\n"' failed. The new value was generated according to [this comment by @japaric](rust-lang#31367 (comment)).
…h-macro-export, r=alexcrichton incr.comp.: Move macro-export test case to src/test/incremental. `compile-fail/incr_comp_with_macro_export.rs` was trying to role its own incremental compilation setup. This started to cause problems. There's no reason to not just make this a regular `src/test/incremental` test. Fixes rust-lang#45062.
Fix a bug in diagnostics for `x as usize < y` Also improve diagnostics for `x as usize << y`. Fixes rust-lang#44406 r? @estebank
Member
Author
Collaborator
|
📌 Commit ce0a1cf has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Oct 10, 2017
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug_structin several Debug impls #44775, Fix typo in codegen test #45089, Ensure std::mem::Discriminant is Send + Sync #45095, Update comments referring to old check_method_self_type #45099, Make the result ofLiteral::string()more readable #45101, Fix data-layout field in x86_64-unknown-linux-gnu.json test file #45108, Fix typos #45116, incr.comp.: Move macro-export test case to src/test/incremental. #45135, Fix a bug in diagnostics forx as usize < y#45146