Reapply "Initial work on formatting headers"#6457
Merged
Merged
Conversation
ytmimi
reviewed
Jan 30, 2025
ytmimi
reviewed
Jan 30, 2025
ytmimi
reviewed
Jan 30, 2025
| let path = segments_iter.collect::<Vec<_>>().join("::"); | ||
| let in_str = if is_keyword(&path) { "" } else { "in " }; | ||
|
|
||
| Cow::from(format!("pub({}{})", in_str, path)) |
Contributor
There was a problem hiding this comment.
Not something that we need to fix right now, but we're potentially missing comments within the visibility modifier. e.g pub( /* comment */ crate /* comment */).
fee1-dead
force-pushed
the
format-header-2
branch
from
2cf961a to
65fb664
Compare
Member
Author
|
@ytmimi I've addressed the feedback and updated the PR :) |
fee1-dead
added
S-waiting-on-review
Contributor
|
@fee1-dead when you get a chance please rebase on the latest |
This reverts commit f2c84b5.
fee1-dead
force-pushed
the
format-header-2
branch
from
65fb664 to
e506f9a
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ytmimi
approved these changes
Mar 20, 2026
rustbot
added
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per this comment.
This reimplements the header formatting infrastructure to resume porting to this system, if there are comments between header parts, we preserve the original whitespace/comments snippet instead of realigning/reformatting them.
This reverts commit f2c84b5.