Prevent false detection of Node.js in Electron#283
Closed
maccesch wants to merge 1 commit intorust-random:masterfrom
Closed
Prevent false detection of Node.js in Electron#283maccesch wants to merge 1 commit intorust-random:masterfrom
maccesch wants to merge 1 commit intorust-random:masterfrom
Conversation
Member
|
Ideally, we would avoid a bunch of platform specific workarounds. Would something like #284 fix your issue? Also, how did you test that this change fixed the problem. |
Author
|
I think #284 might be a way better solution for this. I only tested my solution that it works in Electron. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.