Rework JS feature detection

[josephlr]

This PR tries to incorporate some of the suggestions from #256

The first commit changes our detection logic to first look for the Web Cryptography API before attempting to check for Node.js support. This allows Node.js ES6 module users to add a polyfill like:

import {webcrypto} from 'crypto'
globalThis.crypto = webcrypto

as described in #256 (comment)

We also rename BroswerCrypto to WebCrypto and update some of the outdated error messages and package comments.

The Second commit adds better detection for why we failed to call module.require("crypto"), returning a different error code if module.require is not a function,

I think this fixes #256 about as well as we can.

Signed-off-by: Joe Richey joerichey@google.com

[newpavlov]

Looks fine to me, but note that I am not familiar enough with the JS targets to judge quality of this solution.

[josephlr]

Looks fine to me, but note that I am not familiar enough with the JS targets to judge quality of this solution.

I'm not so sure about the implementation quality myself, I did try changing around some of the names of functions to make sure errors occurred when they "should".

The main feedback I was looking to get was mostly on the documentation, and error messages.

[maccesch]

I'm not an expert for this either but from what I can see this looks like a nice solution.

[josephg]

I left some comments on the related issue. In short, there's a lingering problem in wasm-pack's bundler mode which we could fix or ignore. Either way it looks good to me!

[newpavlov]

@josephlr

The main feedback I was looking to get was mostly on the documentation, and error messages.

Both look good to me.

[maccesch]

Is this going to be merged soon? I could really use this in my project 🙂

[josephlr]

Is this going to be merged soon? I could really use this in my project slightly_smiling_face

Yes, I just need to run a few more checks that we are correctly handling errors when in a Node.js ES module.

[josephlr]

I added e0c93b1 which makes the error @josephg pointed out in #256 (comment) much nicer. Now, if we try to use an ES module from Node.js, we get an error like:

panicked at 'getrandom failed: Error { internal_code: 2147483662, description: "Node.js ES modules are not directly supported, see https://docs.rs/getrandom#nodejs-es-module-support" }', src/lib.rs:9:31

Then if we apply the workaround in our docs, everything works!!

This should hopefully allow users to (a) figure out what's going wrong, and (b) figure out how to fix the error.

[maccesch]

Awesome! Is this going to be published as 0.2.8 ?

[josephlr]

Awesome! Is this going to be published as 0.2.8 ?

See #294