feat: frontdoor via post

[mshanemc]

What does this PR do?

• keep tokens out of urls for human open
• create a small html file locally that redirects to frontdoor.jsp via post
• open that local file in the browser

What issues does this PR fix or reference?

@W-10025523@

also

What does this PR do?
add browserPrivate as an option for --browser

What issues does this PR fix or reference?
@W-14764106@
forcedotcom/cli#2262

forcedotcom/cli#1852

forcedotcom/cli#636

Notes

it is valid to do --json. That'll still have a AT-param in the url for machine use AND do the new open behavior for humans

QA challenges

• does it work correctly on windows (that is, fs and tempDir are working correctly) and across various browsers and shells?
• can you find a way to leave these temporary files on the filesystem with valid AT in them?

[cristiand391]

Looks good, just left 1 suggestion and 2 requested changes.

[cristiand391]

QA notes:

testing done on win10 vm:

❌ tmp file gets deleted too quickly, tried ~20 times with firefox/edge, with them open/closed but by the time they try to access the file it is gone:

NOTE

edited the code to print the tmp file path.
sleeping for 3s works sometimes, but found 5s to be most consistent.

having the browser closed didn't seem to make any difference (I guess b/c the child procecss gets returned once it's opened so the time starts to run after that happens)

If I. delete the await rm line it works on firefox/edge and pwsh/git-bash/cmd

[cristiand391]

QA update:

frontdoor file

windows

✅ browsers can open the file and do auth

sf org open -o cd --browser <browser>, without browser flag it still opens the default.
tested with firefox/edge and latest chrome.
Added a console.log to get the tmp filepath, always get deleted after the sleep (more details below)

✅ file gets deleted even if you specify a browser that isn't installed
uninstalled chrome and ran sf org open -o cd --browser chrome, the tmp file was created and deleted after 7s, exit code 0.

✅ file gets deleted if I kill the browser before the 7s wait

✅ --json withouth --url-only
sf opens the tmp file for auth but still includes the frontdoor URL + AT in json.
json doesn't include path to tmp file
file gets deleted

✅ --json with --url-only
doesn't open browser/doesn't create tmp file. frontdoor URL + AT in json

macos/linux

✅ chrome works (only tried on macos)

update:

✅ firefox works on mac and linux
❌ firefox doesn't open the tmp file

linux: logout, then sf org open -o cd -b firefox opens the org but ask for credentials so it doesn't do the auth.
if I manually copy/paste the file:/// URL it works (redirect -> auth).

macos: logout, then sf org open -o cd -b firefox opens an empty tab.

❌ on linux, if If run sf org open -o cd -b edge without having Edge installed, open crashes and the tmp file doesn't get deleted. Maybe put this in a try/catch block? doesn't happen on mac and win.
UPDATE:
try/catch/finally didn't work because the error is thrown by the child process instance after it gets out of the try block, I still can find the file in /tmp.
What worked:
listen on error even, delete the file there and re-throw the error.
✅ fixed, file gets deleted after spawn error.

--private flag

✅ macos
set chrome/firefox as default, then running the command open both in new incognito window.
not tested: edge

🟡 windows

chrome/edge as default work, new incognito window open.

with firefox it throws this error:

there's an open issue in default-browser:
sindresorhus/default-browser#11

NOTE
that last change to delete the file in the finally block covers this, it gets deleted on this failure.

🟡 linux

can't get chrome/edge installed.
with firefox I get this error:
Error: Firefox-P9tn31 is not supported as a default browser

similar to this:
sindresorhus/open#329

not sure if the fix there was related to chrome only, I'll try to get more info a log a new issue there.

[cristiand391]

1 suggestion about flags and 1 requested change for open's incognito API