fix: decode path flag before writing it to form - #934
Merged
Conversation
cristiand391
commented
Jan 16, 2024
| conn.instanceUrl, | ||
| // the path flag is URI-encoded in its `parse` func. | ||
| // For the form redirect to work we need it decoded. | ||
| flags.path ? decodeURIComponent(flags.path) : retUrl |
Contributor
Author
There was a problem hiding this comment.
retUrl can be either a generated path from --source-file or --path.
If the former that's fine because it doesn't get encoded in generateFileUrl, so we only check for flags.path.
mshanemc
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up from #913
sf org open --path <path>isn't working on current nightly (sf v2.25.5).--pathis URI-encoded by default (for the old behavior of opening the url with the AT + path | source-file as param), but the form redirect requires is to be decoded:tested on macos (firefox/chrome) and windows (firefox/edge)
What issues does this PR fix or reference?
[skip-validate-pr]