Conversation
✅ Deploy Preview for effortless-malabi-1c3e77 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
register.js
Outdated
| }, | ||
| }, | ||
| transform: null, | ||
| target: "es2021", |
There was a problem hiding this comment.
How did we choose this? Any reason not to jump straight to 2022?
There was a problem hiding this comment.
I cargo-culted it from the test-app directory like the grown up developer I am 🤣
I'll update it to es2022
tvanhens
force-pushed
the
tyler/register-hook
branch
from
628f2dd to
c71a946
Compare
| @@ -0,0 +1,26 @@ | |||
| const register = require("@swc/register/lib/node").default; | |||
|
|
|||
| register({ | |||
There was a problem hiding this comment.
Will we need to allow users to specify any of these configuration properties?
There was a problem hiding this comment.
Yes, but breaking this into a separate file and allowing the config to be overwritten seems to be causing the error I was running into yesterday. As it stands, users can still overwrite the config by including a .swcrc.
There was a problem hiding this comment.
My inclination is to get the critical path in place first to unblock the getting started section of the website and then come back and figure out the problem with making this composable. Doing so is a non-breaking change with the hook in place so I don't think it makes sense to block finishing the getting started guide.
| @@ -1,29 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Did you forget to remove the root .swcrc?
There was a problem hiding this comment.
It's still needed for testing. Will remove when I add a jest loader.
Signed-off-by: github-actions <github-actions@github.com>
tvanhens
force-pushed
the
tyler/register-hook
branch
from
f326a5e to
b4168bd
Compare
3 participants
Fixes #