Skip to content

feat: compiler register hook #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvanhens merged 4 commits into from
Sep 9, 2022
Merged

feat: compiler register hook #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c69143f
wip: register hook
Sep 6, 2022
c819743
chore: self mutation
invalid-email-address Sep 6, 2022
819bdd9
sync projen
Sep 6, 2022
b4168bd
re-add swcrc config at root for tests
Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projenrc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const project = new CustomTypescriptProject({
],
eslintOptions: {
dirs: ["src", "test"],
ignorePatterns: ["scripts/**"],
ignorePatterns: ["scripts/**", "register.js"],
lintProjenRc: false,
},
tsconfig: {
Expand Down
26 changes: 26 additions & 0 deletions register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
const register = require("@swc/register/lib/node").default;

register({
Copy link
Copy Markdown
Owner

@sam-goodwin sam-goodwin Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need to allow users to specify any of these configuration properties?

Copy link
Copy Markdown
Contributor Author

@tvanhens tvanhens Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but breaking this into a separate file and allowing the config to be overwritten seems to be causing the error I was running into yesterday. As it stands, users can still overwrite the config by including a .swcrc.

Copy link
Copy Markdown
Contributor Author

@tvanhens tvanhens Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My inclination is to get the critical path in place first to unblock the getting started section of the website and then come back and figure out the problem with making this composable. Doing so is a non-breaking change with the hook in place so I don't think it makes sense to block finishing the getting started guide.

jsc: {
parser: {
syntax: "typescript",
dynamicImport: false,
decorators: false,
hidden: {
jest: true,
},
},
transform: null,
target: "es2022",
loose: false,
externalHelpers: false,
experimental: {
plugins: [["@functionless/ast-reflection", {}]],
},
},
minify: true,
sourceMaps: "inline",
module: {
type: "commonjs",
},
});
29 changes: 0 additions & 29 deletions test-app/.swcrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test-app/cdk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"app": "node -r '@swc/register' ./src/message-board.ts"
"app": "node -r 'functionless/register' ./src/message-board.ts"
}