simpleVCFClient.py needs refactoring

[poddus]

simpleVCFClient.py has similar problems as run.py and batchRequestClient.py (fixed in #2).

• reference genome is int, instead of str
• has batching implemented which doesn't play well with the client, which itself batches by default
• inconsistent line length, longest line is 144 char

[poddus]

also, uses tabs for indentation, which goes against PEP8 (not so important) and is inconsistent with client.py, run.py, and batchRequestClient.py (more important)

[ckopanos]

These utils are being rewritten and will be available shortly alongside a wrapper class for the response. Thanks... Στις Σάβ, 30 Δεκ 2017, 15:19 ο χρήστης Leopold Seckendorff < notifications@github.com> έγραψε:

also, uses tabs for indentation, which goes against PEP8 (not so important) and is inconsistent with client.py, run.py, and batchRequestClient.py (more important) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApDAj9X4vI5XeyprF0-HCjGEn6pt08Vks5tFjh8gaJpZM4RPmL3> .

-- Christos Kopanos RedMob Applications 0030 2431 100 302 www.redmob.gr

[poddus]

is there a development branch for them? I issued a pull request with a number of fixes. I did not change the VCF Client because there is a branch for that specifically.

[amassouras]

Dear Leopold, (cc Christos, who heads our API development) Thank you so much for contributing your updates. These client utils are being rewritten and will be available shortly alongside a wrapper class for the response. We will review your updates and try to incorporate them into our code. Best regards Andreas

…

On 30 Dec 2017, at 22:42, Leopold Seckendorff ***@***.***> wrote: is there a development branch for them? I issued a pull request with a number of fixes. I did not change the VCF Client because there is a branch for that specifically. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHENusOqIXsc-1WYbRtn2NP1dp07wqIpks5tFqAdgaJpZM4RPmL3>.

[poddus]

thank you for creating this api! :)

I have been working on more bug fixes in the client for our own use, but I think the work could be useful for others as well. If you are interested in merging these changes I can issue a pull request, though it would be a rather large one, or I can split it into smaller ones, just let me know.

Kind regards,
-Leopold