fixed a number of problems related to batch lookups.#2
Closed
poddus wants to merge 1 commit intosaphetor:masterfrom
Closed
fixed a number of problems related to batch lookups.#2poddus wants to merge 1 commit intosaphetor:masterfrom
poddus wants to merge 1 commit intosaphetor:masterfrom
Conversation
batch lookups where being limited by the var `max_variants_per_batch`
to 200 variants per GET request, which was inconsistent with the
recommended 10,000 variants per batch, this was corrected in client.py
along with some small readability changes.
batchRequestClient.py
* now uses standard default values implemented in argparse, and takes
advantage of the "chunking" mechanism already implemented in
the client batch_lookup function.
Note that this breaks the "chunk reporting" functionality of the
previous implementation, where a notice was printed to STDOUT
for each chunk. Additional messages were added for the request
and writing the output file.
* The option to pass parameters via CLI was added in a way which is
consistent with run.py.
* ref_genome was converted to use strings instead of integers,
to be consistent with documentation.
run.py was modified for readability and to be consistent
with batchRequestClient.
Note that the default values from argparse are separate from those
found in the client. Calling the variantapi client from
batchRequestClient.py overrides the default value for
max_variants_per_batch.
README was modified to include batchRequestClient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_variants_per_batchto 200 variants per GET request, which was inconsistent with the
recommended 10,000 variants per batch, this was corrected in
client.pyalong with some small readability changes.
batchRequestClient.pyadvantage of the "chunking" mechanism already implemented in
the client batch_lookup function.
previous implementation, where a notice was printed to STDOUT
for each chunk. Additional messages were added for the request
and writing the output file.
consistent with run.py.
to be consistent with documentation.
run.pywas modified for readability and to be consistentwith batchRequestClient.
found in the client. Calling the variantapi client from
batchRequestClient.py overrides the default value for
max_variants_per_batch.