sarif-actual example: set root logger's logging level for Diktat to INFO using logback.xml#405
Merged
Merged
Conversation
petertrr
changed the title
sarif-actual test: set root logger's logging level to INFO using logback.xml
petertrr
changed the title
sarif-actual test: set root logger's logging level to INFO using logback.xmlsarif-actual example: set root logger's logging level to INFO using logback.xml
petertrr
changed the title
sarif-actual example: set root logger's logging level to INFO using logback.xmlsarif-actual example: set root logger's logging level for Diktat to INFO using logback.xml
orchestr7
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for tests until saveourtool/diktat#1394 is addressed, see #401 (comment) for description of the problem. By setting default logger level to INFO we effectively suppress everything that is not SARIF report in process's stdout and save-cli can parse it correctly.
Using additional file to configure logging might look like too harsh requirement to be able to run tests using SAVE, but I think we are simply asking to separate output streams of the process: SARIF goes into stdout, everything else users should be able to switch off, redirect to
/dev/nullor to stderrCloses #401