title pattern for simpler definition#28
Merged
saz merged 12 commits intosaz:masterfrom Nov 16, 2016
pgassmann:master
Merged
Conversation
Without this patch spec tests are failing with the following error:
Resolving dependencies...
Bundler could not find compatible versions for gem "puppet-lint":
In Gemfile:
puppet-lint-variable_contains_upcase (>= 0) ruby depends on
puppet-lint (~> 1.0) ruby
puppet-lint (2.0.0)
Without this patch the use of the limits module in conjunction with the
[pam][pam] module causes the following error:
Failed to apply catalog: Cannot alias File[limits_d] to ["/etc/security/limits.d"] at
/etc/puppet/ghoneycutt-modules/pam/manifests/limits.pp:62;
resource ["File", "/etc/security/limits.d"] already declared at
/etc/puppet/environments/development/modules/limits/manifests/init.pp:15
This patch addresses the issue by allowing the end user to disable management of
the limits.d directory. This is desirable because the end user may still wish
to manage limits using the `limits::entries` Hiera data value in conjunction
with the pam module.
[pam]: https://git.io/v6qAH
Avoid limits d conflict
Add SUSE Support.
Contributor
Author
|
Open for a month. Can you merge and update? Otherwise I will publish it in under my name. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request contains:
The title pattern is inspired by puppetlabs-limits
Only change for existing users is that the filenames could change if $name ist not with .conf and it does not use the username_nofile / default_nofile pattern as title.
How to use
Set limits using title pattern:
Using hiera
Puppet:
include ::limitsHiera: