fix(friends): keep the add-friend dialog inside the window - #84
Conversation
The card surface stacked a 320px QR above the import section — ~890px of content against an 800px default viewport, and the dialog is fixed-centered with no scroll surface, so the title, footer, and close button clipped off both screen edges (worse at the 640px minimum). - card surface goes two-column (QR left at 288, import controls right) inside a widened max-w-3xl DialogContent — ~630px tall, inside the window minimum - DialogContent gains max-h + overflow-y-auto so the scanner and legacy sub-surfaces (which exceed 640 by design) scroll instead of clipping - scanner preview capped at max-w-sm — full dialog width would have made the square preview taller than the window minimum - PairQrCode's building skeleton sizes itself to the requested QR so resolving no longer shifts the pane ~96px Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The add-friend card surface computed to ~890px of fixed-centered, unscrollable content against the 800px default viewport (1024×640 minimum) — clipping title, footer, and the close button off both screen edges. Exactly the reported "QR UI too big, goes over the standard screen size".
max-w-3xl— total height ~630px, inside the window minimum.max-h-[calc(100vh-4rem)] overflow-y-autoon this dialog'sDialogContentso the scanner and legacy sub-surfaces scroll instead of clipping. (Left the vendoreddialog.tsxprimitive untouched — scope discipline; the same latent hazard in other dialogs can be a follow-up.)max-w-sm— it renders a full-width square, which at the widened dialog would itself outgrow 640px.PairQrCodeskeleton now sizes to the requested QR (was fixedw-56), removing a ~96px layout jump when the code resolves.Testing
npm run build,lint,test,check-tokens,check-stringsgreen. Height arithmetic per class values; visual walk recommended at the 1024×640 minimum window.🤖 Generated with Claude Code