Skip to content

feat(friends): cardstock texture behind the add-friend dialog - #85

Merged
scotej merged 1 commit into
mainfrom
feat/add-friend-texture
Jul 25, 2026
Merged

feat(friends): cardstock texture behind the add-friend dialog#85
scotej merged 1 commit into
mainfrom
feat/add-friend-texture

Conversation

@scotej

@scotej scotej commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

The add-friend dialog read as bland — adds a cardstock texture: a whisper-quiet graph-paper grid on the 24px section rhythm plus a faint accent wash bleeding from the top edge. Fits the study-app identity (graph paper) while staying inside the calm direction.

  • Defined once as .texture-cardstock in src/design/index.css, built entirely from the live theme variables (--border-subtle / --accent-muted via color-mix), so dark/light themes and future palette edits flow through untouched.
  • Static background layer only — DESIGN-SYSTEM §6 motion rules and the reduce-motion kill switch are unaffected.
  • DESIGN-SYSTEM §5 records the sanctioned deviation (user-requested) and points any further decorative surface back at §7 rule 3.
  • check-contrast compares token pairs, not rendered layers, so the color-mix strengths are deliberately whisper-quiet (grid at 55% of an already-hairline border color; wash at 10% of accent-muted) to keep worst-case composites behind text-muted comfortably above AA.

Stacked on #84 (rebased onto main after its merge).

Testing

npm run build, lint, test (776), check-tokens, check-strings, check-contrast all green. Existing AddFriendDialog stories render the texture for the axe gate.

🤖 Generated with Claude Code

A whisper-quiet graph-paper grid on the 24px section rhythm plus a
faint accent wash from the top edge, defined once in index.css as
.texture-cardstock and built entirely from the live theme variables so
both themes flow through. Static background only — §6 motion rules and
the reduce-motion kill switch are untouched. DESIGN-SYSTEM §5 records
the sanctioned deviation.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 25, 2026 12:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@scotej, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f594fb1-dc11-47b9-a417-1f2d5ab14cda

📥 Commits

Reviewing files that changed from the base of the PR and between 4ebfed8 and 93b234d.

📒 Files selected for processing (3)
  • DESIGN-SYSTEM.md
  • src/design/index.css
  • src/features/friends/AddFriendDialogView.tsx
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/add-friend-texture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@scotej
scotej merged commit 482b71a into main Jul 25, 2026
4 checks passed
@scotej
scotej deleted the feat/add-friend-texture branch July 25, 2026 12:52
scotej added a commit that referenced this pull request Jul 25, 2026
Textually clean merge; overlapping files (lib.rs, index.css, strings.ts,
ARCHITECTURE.md, DESIGN-SYSTEM.md) touched disjoint hunks.
scotej added a commit that referenced this pull request Jul 25, 2026
Retitle the staged Unreleased section to 1.7.0 and fold in the
user-facing story of PRs #81#85 (Gemma ungated + three quants, the
add-friend two-column layout + cardstock texture, friendly DB errors,
settings spacing) that the wave-3 staging predated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants